Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp334493ybg; Tue, 28 Jul 2020 07:15:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNe1IEyeTZxLr0zL4/4TCss7k+BpoLihU/HjDeV88XKxxGCpkcubtYihzM4ziNw92uQzbu X-Received: by 2002:a17:906:9399:: with SMTP id l25mr17835480ejx.212.1595945740177; Tue, 28 Jul 2020 07:15:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595945740; cv=none; d=google.com; s=arc-20160816; b=UBM/Ul9MGBazNfiNL85L1ed7ksq0xTeETOZsnkfI9fzHLgwuPzoD+h1UD/YXHeIRKV 4mHNnrq79TdwJELj5z35YgD+jw0nCT7uPy9pyeXZpvu3Aw9jJ2lP1EVotJiVew06q+5E 99xYVqRfMveAaAQw4X+TUGc1MWrtsCHkr2hUeBijxgjSKAmwGQ6uEscB5GT8AWFRrGCa Ja32JT1VySgYi9uqa0oYRt05AtsJIyvY96GdA2xbjtRXc4aYSouZLfJiRD4xfUVd3Pww crL1UqVFoc2R9HgkKDUz5L8uMB9q3CXTBT4Bl1YzS3atMuuGXKb10vgWkXIU4xQepjP7 9okA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=rs5ibOGKWRXVbpf5yHwMO8j6h6oLiVC4DnfaYH2lj3M=; b=b2JkvSyHgBt55JYxEryqRbeI5kPGuhAXK4D1giZl6U6yl51BPxqbn4C/fhlDaDYto/ Fa4WDxewis5NvL1ehIEW1Iru9VQFDfzR34mXsRLScs7QOeYPGnO6Dmr2dTp8d3yALCqD NHX0BgPkzEL0bXu+7K9RQ2u1F1TBWFHdqINE0ufva7tjB1wWC6gMTUdvz0+vOgAl6BsS etth4mJ34ipYtYY36XNiBJfVN0zHhQnkuxnR23Rk+u+koaJa/PKGU6BufkXX6zes2bmQ OUDo0qVh0friC0F8fzTwNkJKTYnX+l4v5yC9hodg4CZwpWX2q0YDzW+/MKHpvIEASQhA c2GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BI2EYqoe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj25si5835656ejb.26.2020.07.28.07.15.16; Tue, 28 Jul 2020 07:15:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BI2EYqoe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730389AbgG1OM3 (ORCPT + 99 others); Tue, 28 Jul 2020 10:12:29 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:19148 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730335AbgG1OM3 (ORCPT ); Tue, 28 Jul 2020 10:12:29 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 28 Jul 2020 07:11:44 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 28 Jul 2020 07:12:28 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 28 Jul 2020 07:12:28 -0700 Received: from [10.26.73.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Jul 2020 14:12:24 +0000 Subject: Re: [PATCH] mmc: tegra: Add Runtime PM callbacks To: Aniruddha Rao , , , , CC: , , References: <1595854036-15434-1-git-send-email-anrao@nvidia.com> From: Jon Hunter Message-ID: Date: Tue, 28 Jul 2020 15:12:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1595854036-15434-1-git-send-email-anrao@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1595945504; bh=rs5ibOGKWRXVbpf5yHwMO8j6h6oLiVC4DnfaYH2lj3M=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=BI2EYqoeiBRC5T6zDk9D/ZZ1BSRrdXjUUv1ouhze/xHbpj6/G3zWAbs8BXpP7XxeK ya2do+R9pBTs3Z57uZijm79hKDEOqhj7lymHdwq5KCkHaldT6jYYQ/DO3DYZfU2NCv 6j/8egzzCQRrrJwZlLG80tt5Qpx8dLfKGA4wCe86TZeEJA3SQyOfJ4y8bx/BUengsi ybtr24ceE8njZFcqBR1M1u1VKQydJIKR6O28R3Mfu8aK4UrpX6RboOOSqLR59Q1CN6 TtHeYYoR6rgLRC/6TbQnTXOOWgkMH8W1N7WaeXtGY9EBO1BeE3VTcwUofxINuSHDcg Q5gj1qO+zAezw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/2020 13:47, Aniruddha Rao wrote: > Add runtime suspend/resume callbacks to save power > when the bus is not in use. > In runtime suspend > - Turn off the SDMMC host CAR clock. > - Turn off the trimmer/DLL circuit(BG) power supply(VREG). > - Turn off the SDMMC host internal clocks. > > Re-enable all the disabled clocks/regulators in runtime resume. > > Signed-off-by: Aniruddha Rao This patch is causing a boot regression on Tegra20 Ventana. Other boards appear to be booting fine, but this is breaking something for Tegra20. The bootlogs don't appear to show any particular crash, but I see a hang when initialising the sdhci controllers. Cheers Jon -- nvpublic