Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp360242ybg; Tue, 28 Jul 2020 07:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1QEeabwtP0jCSDNH+04uKLW8K5fUSRVZFzmki9MpEDe4P2mRjA9J4n8OssMwd1aQasMYo X-Received: by 2002:a17:906:743:: with SMTP id z3mr25644105ejb.216.1595947932869; Tue, 28 Jul 2020 07:52:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595947932; cv=none; d=google.com; s=arc-20160816; b=W3VWqKnQL4s8iD4nfrzfskO2xeXQtbVepCWZSS86CQ/mWbZ1v4BBn14oK/2h8w1VNh MazoXmZ7NZJ4C0XXZnnasfX7pzssX4PrhmiZGk+mQVzKiTaW+sQOVpNVQfJgNrRiwoU9 Iyz0a7f/8P2jhOAhlAN09e1v3cJsrrD6WiIUQT2/pihurupJGOzeIT/xtu6KNpRumnOc qa3stfh1qg7y+aRyJguBR3R0/OZLD4beMeq2iWIjgAckkjq7iY1bY0nDxBCm8He3fUxm NVQtRPsvUueYpmeLlcdlq2QXmy5boIe2aGISCskuP3RgtvDPuyxEfDOhrE6T3/5lcm2p pxbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SWjykGqBMInyrV21RjBwz09v26RfChOpFP7bkHaZWz0=; b=wrGNjgubH9MAKLLJFODsa1c3PJFpLgRJ6xPreX+HWaTDyuuf3OQNfmTN+AMXp0KkdO 6xeyuUyEKZB3+aHSFuvNCqbBEgYolO6J9FdW5/ZGxVYVeD6OIcceJUz/bRQYSwE1pr5x z/EPwkPvYZ1XiGYw4WW5Jotnrk63f84WXF42xwgR4OpcxuFg6tZuXvbLOcztdROAFGPV /TsM41JfSZR0qlNInMWBqWirOgviux/IDAtNy+3cqyctaItEIrpplb1dw+wfnjs9dF7c vLabnuBxej7Mm3n3XDjdzSKihY0i+Neh/j2oSE59KQlMe1TWWKsQN8qrfBMYHOU5jvWk n+BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gL5GVj/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si7940815ejb.515.2020.07.28.07.51.50; Tue, 28 Jul 2020 07:52:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="gL5GVj/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730533AbgG1OuZ (ORCPT + 99 others); Tue, 28 Jul 2020 10:50:25 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41529 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730523AbgG1OuZ (ORCPT ); Tue, 28 Jul 2020 10:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595947824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SWjykGqBMInyrV21RjBwz09v26RfChOpFP7bkHaZWz0=; b=gL5GVj/1Sh/8xRJw5I5V5ugR3rF5SX7ApolewQ5v8l+CqxPmRkEddfBM2fWKmPr5o+xPcN PO6qbLkt9MGtlOYHlicpnJv6zjgDQ5AuueMDgHom+I/0sfySeNluYbmZPiFsddK1nz64LJ V/D+dzbLdGSR7NAT/pKGzovSnc4LnMk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-Zrerl_7zO_amUtxi0bg-EA-1; Tue, 28 Jul 2020 10:50:20 -0400 X-MC-Unique: Zrerl_7zO_amUtxi0bg-EA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 31BB6193F560; Tue, 28 Jul 2020 14:50:18 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.181]) by smtp.corp.redhat.com (Postfix) with SMTP id BE9C069324; Tue, 28 Jul 2020 14:50:15 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 28 Jul 2020 16:50:17 +0200 (CEST) Date: Tue, 28 Jul 2020 16:50:14 +0200 From: Oleg Nesterov To: madvenka@linux.microsoft.com Cc: kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 1/4] [RFC] fs/trampfd: Implement the trampoline file descriptor API Message-ID: <20200728145013.GA9972@redhat.com> References: <20200728131050.24443-1-madvenka@linux.microsoft.com> <20200728131050.24443-2-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728131050.24443-2-madvenka@linux.microsoft.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/28, madvenka@linux.microsoft.com wrote: > > +bool is_trampfd_vma(struct vm_area_struct *vma) > +{ > + struct file *file = vma->vm_file; > + > + if (!file) > + return false; > + return !strcmp(file->f_path.dentry->d_name.name, trampfd_name); Hmm, this looks obviously wrong or I am totally confused. A user can create a file named "[trampfd]", mmap it, and fool trampfd_fault() ? Why not return file->f_op == trampfd_fops; ? > +EXPORT_SYMBOL_GPL(is_trampfd_vma); why is it exported? Oleg.