Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp423055ybg; Tue, 28 Jul 2020 09:15:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlYFS3/Vxyjjc014sDGeDCRdd5nFbjd6H6TAHlDqG+r005XeKc0lYXGACLch60AugX/REa X-Received: by 2002:a17:906:1baa:: with SMTP id r10mr136291ejg.389.1595952942455; Tue, 28 Jul 2020 09:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595952942; cv=none; d=google.com; s=arc-20160816; b=n1zFQEbfFE0767zaC+lhDV8wOgKL86MuQ2hJX6oRNjJ1Cua42vAsxsszpM6at96GYQ KgEayCIjGp5UsIiBB6Iyudxv6AaHCLh0DEdkymAYbYQeks34+yLggpom2ZOsVFqynJo0 udAAORS/kIwNi1N8VnZphLyRNy4h/7AXpnP1AfDiB5cU8Hy9Xv4+Qyd0Ul2vDcbWSzGE epY7P+ve81lctc5je33D8Z3JxXxyZu+hYxqKSwWGmGQhskCrsRDdUUuZ2PUwH8jpoieg P6/J3oJcLAtCPbD8ztPGSkJUYgpQMHmZcBkkBF/jqEcs7csKV8esOVEWrZSq4Xdki4wZ f61g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=bNCg05tz8T72EfbSHUoOieVHqqb0riUeyvEBdt6ssUM=; b=HA8gbKdpik6DGl47ZHyS7OFbUxL9EZIk8tykOlsQIS+Kz1om2jJAiKxjOV9aMRg/2j dKKs2ZihEGB8dU5gbbgYjbH17w0NLlh0sZFnHLf1FV8sgIaaJ/1btj+T5XKTjf7SS3z7 kFEIxjKtL1xsLv6038MfmbMrZKEuhcJIjot9LNNx3J/JFTcu/ZPmpcn7AWLzXqF5gw2d gBntm5EOenbOQBG76c4yObSNEexogWH0kSXcKUfFahydHnZiRjqj+PrGiRGf2oZvLyG+ SFFVlGSyAehoq53UB+U0D6Wi73T91Zxr6r0dVcK+XoirIqJDd7pNTlj+8VPHDlP/J0EI G+pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=zRqLODBQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f27si7926845ejf.677.2020.07.28.09.15.19; Tue, 28 Jul 2020 09:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=zRqLODBQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731214AbgG1QNJ (ORCPT + 99 others); Tue, 28 Jul 2020 12:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730586AbgG1QNI (ORCPT ); Tue, 28 Jul 2020 12:13:08 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2FA1C0619D2 for ; Tue, 28 Jul 2020 09:13:08 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id z3so6432879ilh.3 for ; Tue, 28 Jul 2020 09:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bNCg05tz8T72EfbSHUoOieVHqqb0riUeyvEBdt6ssUM=; b=zRqLODBQdmGL+KkPjeEEQSogroxZboQc6kVDb/r8scjUQ6sGp2YTamenSoheM1wlLf nA76+rvaUPd7MDUuJ1LHgS+mtm00OI7G3gOCgKPBm1eF3MVGMnl+BbIG0x+OlItmlQu7 VAilduQlrQNaA6sFrnqTgaw7q0Dgl2sx/uPSKIhTXag0Z68ccFn7crG9fWf1m+JHlIJW yWVonxz6q8KBdNxKRLPxp7+315BKGfTxF+dBHu0sHutbBdqivmUxoKbxYU07jReMfkFn MOpK1aOnBU7aAzMkod2ic1D0bxeWFBv+l+ul7e0zuIXUOmcoNdpE74V5JhKnUS0rsK1P QHbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bNCg05tz8T72EfbSHUoOieVHqqb0riUeyvEBdt6ssUM=; b=YgPYtn6t9qjBNeSDvnVy+6H061qYd2g/VF3V6genDGj8EzlnuiwbCRz+VoYc6uY0qL LzSL8Jlklj8FzvlvoDfsRVgi5o76lGpdPClvefjRanFesSpGvAW+4pd80byDdXUwkVh7 ilBeDqA4rm0PlCxtJaMwJDPBaaHeiYK9l1errPe9eco/rUOJqaq2ZNIahqEe+ZCxBq8r wi7BVqXvO12H0Tyg2TmnIWSOWFVAGLnv70hx24WgfXfJSgxmYmI7D4x2iBlM7cAuBVTz yWhofDXnWCp/rzMB9OumA/QA+qULM40jlKwmR3VHFYdWsQcG6erVfuWBAQLd/p3MO8Vk +w/Q== X-Gm-Message-State: AOAM531qv3WpWjBbePef7ozmaFLJjZTotiAIEj8weeviQKwNa74gAVx/ HF93n5z4oh48LaS7qUc01LioYUH7BQc= X-Received: by 2002:a92:b112:: with SMTP id t18mr20855664ilh.172.1595952787893; Tue, 28 Jul 2020 09:13:07 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id 4sm10149248ilt.6.2020.07.28.09.13.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2020 09:13:07 -0700 (PDT) Subject: Re: [PATCH] block: Remove callback typedefs for blk_mq_ops To: Daniel Wagner Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200728160506.92926-1-dwagner@suse.de> From: Jens Axboe Message-ID: <7a26c550-934b-a188-b910-3d21d006df41@kernel.dk> Date: Tue, 28 Jul 2020 10:13:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728160506.92926-1-dwagner@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/20 10:05 AM, Daniel Wagner wrote: > No need to define typedefs for the callbacks, because there is not a > single user except blk_mq_ops. Concept looks fine to me, but you're mixing indentations a bit. Just remove the indentation bits, we don't need them here. -- Jens Axboe