Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp423396ybg; Tue, 28 Jul 2020 09:16:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlGqSNrnQgZ5DlAzo4w/MPvN0+K0nwo5ubmN6eyS5zHZa3ezf15mMtQj0YX8W97I+QJyA0 X-Received: by 2002:a17:906:7787:: with SMTP id s7mr11167803ejm.533.1595952972454; Tue, 28 Jul 2020 09:16:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595952972; cv=none; d=google.com; s=arc-20160816; b=RejTu5Hz3ZZcMWCME9JIB/NgzXHfc+tcQF7U4nhWhq1Gswb7ovKd2AbZtqCvmA103I zb5hPcqAlRUtTeG8dvey/26fkucldNe4/AaDzbykgZ4HTJGYXPx7QQtNq8/sCR6tPeSS Dt6RbV9LfVqtmyDyUule+Mxr+F8UD+50n/hCMa2s9rNcB1INxGe2S/77GExSwXIMkgEM eLMsiYFTdzcmYKD7lLaFG33fdaAk+J015mtsmF9v2+NcwFiKgFNlk369S7vBiy3R8bjI LssNPpqNM7Pj8zWw+fTFqqZjFuB1qWae6Lr/Y963ZKULQtqYDbQR2vFiFBlmX6L4W6QW YSoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ockVMft3pbIwfqvxJGITTu41eFRmrEm9KwYoKpNmpps=; b=YqzTA290Dz+rsiiezk4cMlbwtpdPT6C10Xp/Z3ExtIZrRp7WTH9giTSzjcDX/LV1gN uCUxJ9m8Ge9hnc8/H5PWErEE4hTQSAwzRKBub0bFtJaBZuWrcEY54AFSIDWcxML+DA9J ER/VZNxtJu1MNnA71sGT1tY8Qu0ZU++/dbvMKG1LaCqZO+USmL2JwUpODNt7+cxPIuyQ AV97ILw6Ce7tzr1Thm7tHaNSN8v18UcdIGIPoXmGwfd8BX+BB92qUNbJs9nbLOc1V8J0 U2P38OLw3QHbi0K5vtA0D08f2cL5YS3RPucnEiJI4Re5Cymve8C4vtKY2wxg/D43NYZL mNGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x4si3153325eju.496.2020.07.28.09.15.45; Tue, 28 Jul 2020 09:16:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731335AbgG1QPG (ORCPT + 99 others); Tue, 28 Jul 2020 12:15:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:46574 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730586AbgG1QPG (ORCPT ); Tue, 28 Jul 2020 12:15:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DDBD7B5BF; Tue, 28 Jul 2020 16:15:15 +0000 (UTC) Date: Tue, 28 Jul 2020 18:15:03 +0200 From: Daniel Wagner To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Remove callback typedefs for blk_mq_ops Message-ID: <20200728161503.657ch75lxbky4tvb@beryllium.lan> References: <20200728160506.92926-1-dwagner@suse.de> <7a26c550-934b-a188-b910-3d21d006df41@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a26c550-934b-a188-b910-3d21d006df41@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 10:13:06AM -0600, Jens Axboe wrote: > On 7/28/20 10:05 AM, Daniel Wagner wrote: > > No need to define typedefs for the callbacks, because there is not a > > single user except blk_mq_ops. > > Concept looks fine to me, but you're mixing indentations a bit. Just > remove the indentation bits, we don't need them here. Ok, in fact I was not sure about the indentation. Let me respin it.