Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp431053ybg; Tue, 28 Jul 2020 09:28:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzI9wPZjJEiS0w+xYcJ3xilGGJBtV0OUCRlEPRlTmVcl0vRlGu5E5K9xoB3eKq/hqh56aN X-Received: by 2002:a17:906:1bb1:: with SMTP id r17mr20730572ejg.268.1595953705560; Tue, 28 Jul 2020 09:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595953705; cv=none; d=google.com; s=arc-20160816; b=CPyRPkjwbj/6dWCHba0V5uD9wIeT4F1gbFhjXvgiZWpxnkG/oFe0bcRcTVRfV5/aG6 9ERU4z7GmfYQhsJZgS2jimAlvOJHx+zbI+lq84473mq35TdYElCtejR7pUdF/7EHKwWu 8nMiX4VuFizDUjZG+0WVtEv9tkfMLtakkrodxReX3OVo7CpgTFtD0Ge8pXbtU1BSNqyi ucbEbsgu+24LHChqkvAZRIADGabz3UlW6WIF8CS7cu23zZaVu3Ts8F2mfRmM0oGD9Pe0 8sVixBwaxyQIPGA0OHmRlSkbODJMNglZImc17Li03Iue9wIIQqKq7hZJzny108WuWDFy CHPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=MYT8/3K7R/c49QbezBV5IoadxtpkYqUZBsW74I/Bodo=; b=0iCpwtoaCtWMtWE6GB679f31CshDBqktfmi1+gKI3JYED0hP7PBlHo4DMzprEUh7Cu u/L3vcxRmvZAP/yTKJHFlbhpacPaj+bsO0Ijs/66HXszKKcXa/bQz/MSvUzcmwuPSOX5 xF3Bv3nYBuDIzRbQOZNypbhNM9KwsOTHJEb4mdmjTGuCp9JkqFwZ6mjS1iet4eBzvoWT PwzKaiITXP6FLPAJbF8xAYNVijIAW27KdQcWs0iMsaMVF5Np4sMqHsTHfKi0757ysiQH Cy0Vyz5HI/tccQcIn92V852wbnuPsOwgk7Jz/nTL/7bQRpRtw74REDQT+CWNAnfq8N2H z38A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Z/LMp3e9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y1si8188356edp.472.2020.07.28.09.28.01; Tue, 28 Jul 2020 09:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Z/LMp3e9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731328AbgG1QZn (ORCPT + 99 others); Tue, 28 Jul 2020 12:25:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731318AbgG1QZn (ORCPT ); Tue, 28 Jul 2020 12:25:43 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34C17C0619D4 for ; Tue, 28 Jul 2020 09:25:43 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id d18so21394039ion.0 for ; Tue, 28 Jul 2020 09:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MYT8/3K7R/c49QbezBV5IoadxtpkYqUZBsW74I/Bodo=; b=Z/LMp3e9hgnHv/y2/1uciK3aP6hkPDVj/2+kga+pm4sBvwUogma5yUVi7EjxmSiq0s y4mmWN0OT92cwabH8ObN26Eqc6Bvq4m+BI7e4nXCq00b/h9A/gavGlUsmj0sBaFkeHet jGUJQBGnWgORdiaHk27mg1Efw6KMWcSzTpzGXgQNinC8/yfKrva8LA6PMI4ntPLz/Md5 cN1YEYjYhm8TwgrM/N9CVTR7aE7/ZVAEqztrMnlIbc+ASgV9YV9uwPIgI34V40N5zztF o47SCW6+KLK/qPdCzDAYMhmiY98BPdbUPhrqwPTfMsErfUcD4V98qs8z2amEXizeHX/k s2qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MYT8/3K7R/c49QbezBV5IoadxtpkYqUZBsW74I/Bodo=; b=MuYlUn8YncSy/wsxKcA3TPgiJcZ2G7djW6eDt7qwRoWWeCdWWBGWFAX5P0QRhFdKJd HQuEem0uSHWZJhji3Kk7A+HVWGBM/lFYXV0PtQBI0tZQHWz3kR53CoBKNZu2YrAPIPqg qBCkmzSUn+75L9yx4vLYSFAJ2yeHL/sH8FcNJCnrt33+6uqAjlvkVa8KTC1meXX9YlgX 6r7D6VBbKKsD13PLoz9hZfSL0JA1S7p2SDx3OyECKaoXV8/zeSV70kivxUWXwicbKKVK iMKHkQcCe3n/sxYG+OFPHzwg/nMV2jsy3rfP1XtKKh/H4WIW7HOzARLeicTVDsEoQm7x dy5w== X-Gm-Message-State: AOAM533v7zF/0u8L4yXhLAeCWN3AK3wb7kQyjTRwcS+B7hdemymLzbNg P8e61B5t3cXdsDwtmOyEpze2KWNU7FU= X-Received: by 2002:a02:a389:: with SMTP id y9mr5185167jak.82.1595953542342; Tue, 28 Jul 2020 09:25:42 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id m184sm6240904ioa.12.2020.07.28.09.25.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2020 09:25:41 -0700 (PDT) Subject: Re: [PATCH v1] block: Remove callback typedefs for blk_mq_ops To: Daniel Wagner Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200728162036.118211-1-dwagner@suse.de> From: Jens Axboe Message-ID: Date: Tue, 28 Jul 2020 10:25:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728162036.118211-1-dwagner@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/20 10:20 AM, Daniel Wagner wrote: > No need to define typedefs for the callbacks, because there is not a > single user except blk_mq_ops. v2 I guess, but looks good to me, thanks. -- Jens Axboe