Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp435876ybg; Tue, 28 Jul 2020 09:35:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztwuf/T3uVTptPSAv8FT4RS9UBWHNN9hlYlE/q1p65RlNMuPiquA9ZEn9jw/lrGkNiXsou X-Received: by 2002:a17:906:36da:: with SMTP id b26mr17388074ejc.45.1595954134889; Tue, 28 Jul 2020 09:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595954134; cv=none; d=google.com; s=arc-20160816; b=IOsTjwwtqBprmX8w/8uh67D+MBjrdabh3xCNJPY7lHA81UVb5XwD1EUzS9vb1pPwBl apZdwO2lw6MZo1PD5DC5KDryKy7v7VdfcLZkZaabL0Kvn8hHurBAQK4+xecRnJnG6M41 jMfYAD/vi30f6lqS9LQFBxAPSBmXI2HG8eaamwOr7EpMrLl4MYNaKK8FdzSiC3WCkQhA Rvflam7oZEaCzLnj88meKuKVZ7x2L15b50VP/AsGsxPJpBU2XEhmp3sBz4atIX+1FRzg pYyCORrbzl6PkamqdLRT/a1+auRgKPr2GTkzVv1VBiwsubP98HOy7jUZ+oRtx/zOYiLn hmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:subject:references:in-reply-to :cc:to:from:date:dkim-signature; bh=H2uWn5X76XgImjNNUOwuwvqpFqQhWyyxQudFr9pXfaA=; b=O85uGvwP3qJUIHwyIwaszS3L7eMOxY8QzHn4C9KaxvQNezG9RogKsTIllHDZXfqchS fxDhxR+gnNC5VZhC+zLMHLk8BGK7WTG5RpWj9KccRlXq4oJaCEo15elOopDqI5v1ss7Y hL6N/63YENfXK9utAddfv1J5ceCFl7aYBilM3aX+xDkB3zjKHpOe0TvfpPHq3PXT2IGj WhgK3ZAbqY+sQXw0Jy/QTZpfHu093TuJXq7FDKAovlptwJWKVq65AeUREdXoWHPE3m/F NxodtS8N/oXTAv4W1JbE4lemOVff3HiXrKj0Ipa7dz4DKxcbkFKuU0ayTSwF3iqSeXp2 YNwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J5LDSWxe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si7509186ejx.656.2020.07.28.09.35.09; Tue, 28 Jul 2020 09:35:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J5LDSWxe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731480AbgG1QcA (ORCPT + 99 others); Tue, 28 Jul 2020 12:32:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:47684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731458AbgG1Qb6 (ORCPT ); Tue, 28 Jul 2020 12:31:58 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64575207F5; Tue, 28 Jul 2020 16:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595953918; bh=fMNQi5A+NN2YwKr4BGffFEl5pIiiOIfMgqPkYAoC4Ts=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=J5LDSWxez+sdvsG5Q86BG2VchGVcuv+Ij5o934S/xyclHizLJ/DeUsKu94yFSRiyF zNwCTBa0xwGxWL6dTrstVII8B1s3mfB1uLSceZ3HCheQ7am8GFyOsG2DpO0hh/SH35 YHc30CVV2cx04Nx81hneZecSPYBBAikJZ+xk4m6c= Date: Tue, 28 Jul 2020 17:31:40 +0100 From: Mark Brown To: Vaibhav Gupta , Andy Shevchenko , Bjorn Helgaas , Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org In-Reply-To: <20200727172936.661567-1-vaibhavgupta40@gmail.com> References: <20200727172936.661567-1-vaibhavgupta40@gmail.com> Subject: Re: [PATCH v3] spi: spi-topcliff-pch: drop call to wakeup-disable Message-Id: <159595388005.15302.729932493645865477.b4-ty@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2020 22:59:37 +0530, Vaibhav Gupta wrote: > Before generic upgrade, both .suspend() and .resume() were invoking > pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both > states. (Normal trend is .suspend() enables and .resume() disables the > wakeup.) > > This was ambiguous and may be buggy. Instead of replicating the legacy > behavior, drop the wakeup-disable call. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-topcliff-pch: drop call to wakeup-disable commit: 15b413d93ccd0d26c29f005df82c299c8f14cbd6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark