Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp445386ybg; Tue, 28 Jul 2020 09:49:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzROAjzKbolDKHlo3mlHPovMAnZUAFwVjsttf0rd+jl8i4ocxT/UFlgRtdFm6aCyosBZByI X-Received: by 2002:a17:906:8595:: with SMTP id v21mr27277964ejx.333.1595954942915; Tue, 28 Jul 2020 09:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595954942; cv=none; d=google.com; s=arc-20160816; b=cPtvslaArKdef1+HC7KCD9SGN9NW/n3zwbvBLw60Na26ByDhp/zOqZW/0gS4VkJHEC 53+xB03xQ5sBC0hBIRAFUFKihAUywpxyDr31QQVOvPc87gNqS2feF0BVLJ2kUAFJPdl9 Ms7Z/katwOwYLL1GSkN6ZCHJi7OfFe1/5bIyy3QgEh3s5jUq2c0py+FTBqdsW+3D25P7 pzVpbBzfA4skjqJ0vyr70WPH4SUdE04yjJjFQXnngKZwrh6zpaEz2xqPG6z7GiQszzw7 BglNuZOatKAsDF0FRH8Gz2MDlsMg0tmj6mEV6uVvHZTtI6r9dfIjFW4vgMEzNXZTNm0+ qvyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject:ironport-sdr :ironport-sdr; bh=IHfLLyL+4Z04vG9W3mhRWhJf2FtUod63ouhuwJAX0EY=; b=gOPm30j3HpkQMX3v44aRHPjawhkDQLEeNZ+u3m2xRl8D71T7sSUriizB4Jff+mUL6A xmxN5IOtm2mYb8oNuPtuKbtt9ZZ+e7+P0GyTVkaAg2NfM5g40Gm7bFx7GNNqXiDl4xqa lG9PPrGakL8fPU0gdalAejm0c09ZywMFKfJ9m1BXRg1xreI2EDFMFf4dDuchbYOqMUfu 3TNo27myxpqox+7hPqlTCYc8JFtDL8M51b6Z+3Iq/if1pxUfymZcd2L8DsfBzxJWlBKM rJR1RT8/NfzZ7PFFQDtCpfCeLuRYArLpGzpffi8sYVZuoV74XbW4bYTrJRNyU83/Uw6a OR2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si8465116edk.332.2020.07.28.09.48.39; Tue, 28 Jul 2020 09:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731522AbgG1QrC (ORCPT + 99 others); Tue, 28 Jul 2020 12:47:02 -0400 Received: from mga03.intel.com ([134.134.136.65]:41219 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731367AbgG1QrC (ORCPT ); Tue, 28 Jul 2020 12:47:02 -0400 IronPort-SDR: qOp/igNART18hMf8hCQd8AvB8ZXB6rIXt0hehtZz8vJxCOHX+1K2LofWm+FHfG62Hfy8k9cmLg hqnLfXzy9gXw== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="151243340" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="151243340" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 09:47:01 -0700 IronPort-SDR: HOCJ58r9NCmaV92jA5eIdEDKgSCdVuCAJp78Tf1sEEJklyJzOog/+gsyX56U3XbRkor77eKVqv ZAvDPYcCIJqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="434382778" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [10.212.32.199]) ([10.212.32.199]) by orsmga004.jf.intel.com with ESMTP; 28 Jul 2020 09:47:01 -0700 Subject: Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command To: Jiri Pirko , Jakub Kicinski Cc: Moshe Shemesh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jiri Pirko , Vasundhara Volam References: <1595847753-2234-1-git-send-email-moshe@mellanox.com> <1595847753-2234-2-git-send-email-moshe@mellanox.com> <20200727175802.04890dd3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200728135808.GC2207@nanopsycho> From: Jacob Keller Organization: Intel Corporation Message-ID: <464add44-3ab1-21b8-3dba-a88202350bb9@intel.com> Date: Tue, 28 Jul 2020 09:47:00 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <20200728135808.GC2207@nanopsycho> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/2020 6:58 AM, Jiri Pirko wrote: > Tue, Jul 28, 2020 at 02:58:02AM CEST, kuba@kernel.org wrote: >> On Mon, 27 Jul 2020 14:02:21 +0300 Moshe Shemesh wrote: >>> Add devlink reload level to allow the user to request a specific reload >>> level. The level parameter is optional, if not specified then driver's >>> default reload level is used (backward compatible). >> >> Please don't leave space for driver-specific behavior. The OS is >> supposed to abstract device differences away. > > But this is needed to maintain the existing behaviour which is different > for different drivers. > Which drivers behave differently here?