Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] /proc/PID/smaps: Consistent whitespace output format
To:     =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20200728083207.17531-1-mkoutny@suse.com>
From:   Yang Shi <yang.shi@linux.alibaba.com>
Message-ID: <03206c8c-0350-3b91-fb2d-2f25a6ff4f55@linux.alibaba.com>
Date:   Tue, 28 Jul 2020 09:57:50 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20200728083207.17531-1-mkoutny@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/28/20 1:32 AM, Michal Koutný wrote:
> The keys in smaps output are padded to fixed width with spaces.
> All except for THPeligible that uses tabs (only since
> commit c06306696f83 ("mm: thp: fix false negative of shmem vma's THP
> eligibility")).
> Unify the output formatting to save time debugging some naïve parsers.
> (Part of the unification is also aligning FilePmdMapped with others.)

I recalled someone else submitted similar patch before. But my memory is 
vague. Anyway it looks fine to me to make the parsers happy. Acked-by: 
Yang Shi <yang.shi@linux.alibaba.com>

>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
> ---
>   fs/proc/task_mmu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index dbda4499a859..5066b0251ed8 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -786,7 +786,7 @@ static void __show_smap(struct seq_file *m, const struct mem_size_stats *mss,
>   	SEQ_PUT_DEC(" kB\nLazyFree:       ", mss->lazyfree);
>   	SEQ_PUT_DEC(" kB\nAnonHugePages:  ", mss->anonymous_thp);
>   	SEQ_PUT_DEC(" kB\nShmemPmdMapped: ", mss->shmem_thp);
> -	SEQ_PUT_DEC(" kB\nFilePmdMapped: ", mss->file_thp);
> +	SEQ_PUT_DEC(" kB\nFilePmdMapped:  ", mss->file_thp);
>   	SEQ_PUT_DEC(" kB\nShared_Hugetlb: ", mss->shared_hugetlb);
>   	seq_put_decimal_ull_width(m, " kB\nPrivate_Hugetlb: ",
>   				  mss->private_hugetlb >> 10, 7);
> @@ -816,7 +816,7 @@ static int show_smap(struct seq_file *m, void *v)
>   
>   	__show_smap(m, &mss, false);
>   
> -	seq_printf(m, "THPeligible:		%d\n",
> +	seq_printf(m, "THPeligible:    %d\n",
>   		   transparent_hugepage_enabled(vma));
>   
>   	if (arch_pkeys_enabled())