Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Jul 2020 20:17:55 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Dan Murphy <dmurphy@ti.com>
Cc:     afd@ti.com, pali@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        robh@kernel.org
Subject: Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561
 Battery monitor
Message-ID: <20200728181755.6bkhp7j3cqtpooof@earth.universe>
References: <20200728141113.31518-1-dmurphy@ti.com>
 <20200728141113.31518-2-dmurphy@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5wfexptlluq3ij3y"
Content-Disposition: inline
In-Reply-To: <20200728141113.31518-2-dmurphy@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--5wfexptlluq3ij3y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 28, 2020 at 09:11:11AM -0500, Dan Murphy wrote:
> Add the Texas Instruments BQ27561 battery monitor.  The register address
> map is laid out the same as compared to other devices within the file.
> The battery status register has differing bits to determine if the
> battery is full, discharging or dead.
>=20
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  drivers/power/supply/bq27xxx_battery.c     | 68 +++++++++++++++++++++-
>  drivers/power/supply/bq27xxx_battery_i2c.c |  2 +
>  include/linux/power/bq27xxx_battery.h      |  1 +
>  3 files changed, 70 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/suppl=
y/bq27xxx_battery.c
> index 942c92127b6d..654d38bcd7e0 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -43,6 +43,7 @@
>   * http://www.ti.com/product/bq27411-g1
>   * http://www.ti.com/product/bq27441-g1
>   * http://www.ti.com/product/bq27621-g1
> + * https://www.ti.com/lit/gpn/bq27z561

Applying this failed, because I applied a patch converting the
http urls to https. I would have fixed this silently, but it made
me notice the chip name is bq27z561 instead of simply bq27561.

You named it without the 'z' everywhere, is there a reason?
Searching for bq27561 basically only finds your patches and
you decided not to drop the z for the bq28z610.

-- Sebastian

--5wfexptlluq3ij3y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl8ga8YACgkQ2O7X88g7
+pq61A/9HALzLbaV2nB6FTOZLs3BMj4LSQ1/WIesGXn03CnKce4akvgjygjlAbhj
NYTXV/3SbI8BXgfnTd6ooetOqVmRwoHOo7Z7wtNCTyW38v53uM60GX1TGEiEVSb1
2SD/2W/vzmOjQfsWKm5+xTfhpBPFnV4Y2KTnmgzVBUtiI+dXUdc1FLSBNfksQnlL
nS2f7BN1IWUaaR0GyUub2yeaExzpEDvYritor9tbDBH3IFjYoRrDsBkyp3DFh9fG
+9nlNjIz7QkE5yjaCx68/iZfjSSAEWv28DTjSo7dh24fBrshz4dQ1185Tb7Xiz9F
POa9E+Cl4VhhDd5QWDCgo9VC392TZE5GRhFTJwXT25RJ1sn5A+zFVYxKK35aks92
DKXLmFVUMG2fF3aULBl2mHFccxKq4TIDR9BZypBgjOkyt74NgW6CrJnCU2cleWet
N3XrKiyK901IAd/BF+YLthmuTfiolFz3jwkpgIzix4A6fJ1+dOzXamL/TLk2dT8w
MdR5dRnZwgGNYk3R/GsgE36VXLjIvgMtjvAwbD9ergm8XqiBr5Hk+ooUr3o+CPmF
ilRQ7h7pwhIjnmnqdr7ZHrzNFgjT9rIBt7lSbKi2SrI2hNBNe/GBoe49AcvJtqlt
M5nV4tgf91iZ0bTTlHfgcnxtBX5OhDWXdM257OZtjdz8e3Agf/M=
=pMEP
-----END PGP SIGNATURE-----

--5wfexptlluq3ij3y--