Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp567271ybg; Tue, 28 Jul 2020 13:01:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8zR/UKsF/wPljLhQL1Fqd7cDzjfLhyHWXfiblMrkTSP1BmVEKfNG5mTXxSNVd9gno3JKP X-Received: by 2002:aa7:d458:: with SMTP id q24mr27460145edr.25.1595966480230; Tue, 28 Jul 2020 13:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595966480; cv=none; d=google.com; s=arc-20160816; b=mXgjBx6r830looJU2kt9QrlJ65wTRAybmr/5pfKynfgUbnfXUIcun+MuleOUjcFa6S /lDm8XedzRCpQN/X9Xiu0acP5rwwzO34m+F/bOCGzYXYAT9+o3t5wr7HcyFNxm8Ac8ti nT7RdDHzHM2g1LAXK5JXe6iy1sokJ2dw00UFOIBCEBlJxm02PJtqIuRx2V3JxpMdt74v eA6C7HKys+qPftm+NCpMpqmYTfiJb7Embk/FRY4yOpkncYJTptX+t3Rvfl5hRrRRhSba QDgHpjbUbaiHhS3S7q0MUGAWDO5Darb5iE6Gv0TD3b82HE0o/JllCpOb4oNzMxjbNGxO j29Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YXZG8BYjPil19llmJAZPbDGrivY4sl2bmMKwQ2+Gh5E=; b=SNVhhnQzfEBDJQJ12b+yKBWPilGrl6hvl1DDPtSTDjCopaOhulOdj28MawBVFWIL59 eDvuNhG9aa7qiZgDac0ni4y5SJztOb0cvXL8Fx4buPoBk4ghC+ylllNvYPSyStJYYnp+ LntL7HnGNh5wDk2BuPvo7UqZw4/D+TPyboLG63g4EMHPBDkKPGc96QnSQD95uSuAZAyZ G5J0h8XuAJls89omXm4wmKOEgGAxZiYZG6w9iwRN6RQDR5iPIUQ0pzhUTeOdCg0q4Bls GbWzsGMyOw5jDuSvp1PGQkQzkumETBB9IkzRJaWmEYTe9UiXytliEBzZxmUeqTci8DRQ maoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CohcHiDj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si8263458edw.223.2020.07.28.13.00.58; Tue, 28 Jul 2020 13:01:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CohcHiDj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729426AbgG1S13 (ORCPT + 99 others); Tue, 28 Jul 2020 14:27:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbgG1S13 (ORCPT ); Tue, 28 Jul 2020 14:27:29 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86D10C061794 for ; Tue, 28 Jul 2020 11:27:29 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id l12so1383459pgt.13 for ; Tue, 28 Jul 2020 11:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YXZG8BYjPil19llmJAZPbDGrivY4sl2bmMKwQ2+Gh5E=; b=CohcHiDjJevVL3xTskTg8UI/7ACymEi0XnGBqWgyAIVYZQnk4hvgWyJCymlDwSor41 x4ier7vzVCcGTyX6rJLNjK7mI5gPb0b3+4+kElVEMaYIrCvs7GLB/RaJ+x39nC3ZB9yi Ff4oH3xaxJyK1I5ymnSdzMFXHosRqYRP/mxjc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YXZG8BYjPil19llmJAZPbDGrivY4sl2bmMKwQ2+Gh5E=; b=cLKFlbqC0V7WzuMdmtaDLqfiAzVnxQBTMNF4Rx2I7WBhddRH2DiZfXzyVAGLbfbsaH 6ZQqUWBscPiFdTGuIfDMs5McjRkS/njCzTbK1kTeUV9ADB9QPuLsxdwtckPlwunY4j8g bu0kKwrqgyO1oh2Y+jOalzC9RO/Y4j1DTxiQwqK9MC0EhKb3K1PtBhzoNsm7AIlTcCyE jkYqvqXmFBY3bU54kclmXTD6RBCCn+8uS/ypEuC9CQidTVOMKm7yb5v5mWj0e5hwgMts HbCbE3lxM4KMzjYT9vdP7vG4tZxyYg95REmLZ9Km6vYm5eEhQqEbsYznLGryfr1Rafah GywA== X-Gm-Message-State: AOAM533ICibmV8KR5ebpZd+573cC/nlStA5xngd/xM3IPBX8sX6uhOTG wPK67kMvYQ9gRcF4Zk9h5ccrVA== X-Received: by 2002:a63:e50a:: with SMTP id r10mr25103003pgh.285.1595960849137; Tue, 28 Jul 2020 11:27:29 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e137sm2475286pfh.7.2020.07.28.11.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 11:27:28 -0700 (PDT) Date: Tue, 28 Jul 2020 11:27:27 -0700 From: Kees Cook To: Arvind Sankar Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/8] x86/kaslr: Fix process_efi_entries comment Message-ID: <202007281127.D3E4F41C@keescook> References: <20200727215047.3341098-1-nivedita@alum.mit.edu> <20200727230801.3468620-4-nivedita@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727230801.3468620-4-nivedita@alum.mit.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 07:07:56PM -0400, Arvind Sankar wrote: > Since commit > 0982adc74673 ("x86/boot/KASLR: Work around firmware bugs by excluding EFI_BOOT_SERVICES_* and EFI_LOADER_* from KASLR's choice") > process_efi_entries will return true if we have an EFI memmap, not just > if it contained EFI_MEMORY_MORE_RELIABLE regions. > > Signed-off-by: Arvind Sankar Reviewed-by: Kees Cook -- Kees Cook