Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727184506.2279656-1-guro@fb.com> <20200727184506.2279656-33-guro@fb.com>
 <CAEf4BzbCzEOKx2GMOcp6CTxBBN+BRAY-Z_mCJ26hoSto956KBQ@mail.gmail.com> <C739D492-23E2-4823-8A9A-81BF00FD450E@fb.com>
In-Reply-To: <C739D492-23E2-4823-8A9A-81BF00FD450E@fb.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Tue, 28 Jul 2020 11:30:04 -0700
Message-ID: <CAEf4BzaNEnK6UpfvPpEPpU+fLi=Zsrr5YUc0+t20a_TK_oj22A@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2 32/35] bpf: selftests: delete bpf_rlimit.h
To:     Song Liu <songliubraving@fb.com>
Cc:     Roman Gushchin <guro@fb.com>, bpf <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 11:11 PM Song Liu <songliubraving@fb.com> wrote:
>
>
>
> > On Jul 27, 2020, at 11:06 PM, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> >
> > On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin <guro@fb.com> wrote:
> >>
> >> As rlimit-based memory accounting is not used by bpf anymore,
> >> there are no more reasons to play with memlock rlimit.
> >>
> >> Delete bpf_rlimit.h which contained a code to bump the limit.
> >>
> >> Signed-off-by: Roman Gushchin <guro@fb.com>
> >> ---
> >
> > We run test_progs on old kernels as part of libbpf Github CI. We'll
> > need to either leave setrlimit() or do it conditionally, depending on
> > detected kernel feature support.
>
> Hmm... I am surprised that running test_progs on old kernels is not
> too noisy. Have we got any issue with that?
>

For libbpf CI we maintain a list of enabled/disabled tests that are
not supposed to succeed on a given kernel. So it works OK in practice,
just needs an occasional update to those lists.


> Thanks,
> Song
>
> >
> >> samples/bpf/hbm.c                             |  1 -
> >> tools/testing/selftests/bpf/bpf_rlimit.h      | 28 -------------------
> >> .../selftests/bpf/flow_dissector_load.c       |  1 -
> >> .../selftests/bpf/get_cgroup_id_user.c        |  1 -
> >> .../bpf/prog_tests/select_reuseport.c         |  1 -
> >> .../selftests/bpf/prog_tests/sk_lookup.c      |  1 -
> >> tools/testing/selftests/bpf/test_btf.c        |  1 -
> >> .../selftests/bpf/test_cgroup_storage.c       |  1 -
> >> tools/testing/selftests/bpf/test_dev_cgroup.c |  1 -
> >> tools/testing/selftests/bpf/test_lpm_map.c    |  1 -
> >> tools/testing/selftests/bpf/test_lru_map.c    |  1 -
> >> tools/testing/selftests/bpf/test_maps.c       |  1 -
> >> tools/testing/selftests/bpf/test_netcnt.c     |  1 -
> >> tools/testing/selftests/bpf/test_progs.c      |  1 -
> >> .../selftests/bpf/test_skb_cgroup_id_user.c   |  1 -
> >> tools/testing/selftests/bpf/test_sock.c       |  1 -
> >> tools/testing/selftests/bpf/test_sock_addr.c  |  1 -
> >> .../testing/selftests/bpf/test_sock_fields.c  |  1 -
> >> .../selftests/bpf/test_socket_cookie.c        |  1 -
> >> tools/testing/selftests/bpf/test_sockmap.c    |  1 -
> >> tools/testing/selftests/bpf/test_sysctl.c     |  1 -
> >> tools/testing/selftests/bpf/test_tag.c        |  1 -
> >> .../bpf/test_tcp_check_syncookie_user.c       |  1 -
> >> .../testing/selftests/bpf/test_tcpbpf_user.c  |  1 -
> >> .../selftests/bpf/test_tcpnotify_user.c       |  1 -
> >> tools/testing/selftests/bpf/test_verifier.c   |  1 -
> >> .../testing/selftests/bpf/test_verifier_log.c |  2 --
> >> 27 files changed, 55 deletions(-)
> >> delete mode 100644 tools/testing/selftests/bpf/bpf_rlimit.h
> >>
> >
> > [...]
>