Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp568881ybg; Tue, 28 Jul 2020 13:03:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6TRQlLaPrxzFppaT4RTZapauk/dTyE6G2zUJ0MKgVe7BBPRfXLYt0pk4XMuwysNIx7wpJ X-Received: by 2002:a05:6402:310d:: with SMTP id dc13mr9008417edb.44.1595966593140; Tue, 28 Jul 2020 13:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595966593; cv=none; d=google.com; s=arc-20160816; b=QfGMcVk1nmX793vWxmyO0RVXeTSmJSi0keWk/22IZjkkx24N7IRnTYQ8wxTUoK2dbr zoJ5XjWNG/ruIP/MuX9/7HkmIXlRqCRyKMTR+rzI3qVT2pVIfKA9EDlHIeZ6ksxkLJEM 8/P4p8wsqJUYig5y19KTfTYSr49CzfaW58mZARqRTZC+kCwtuXRdOcHbyOHvlLnguV6y QaLMZTzBSVXSO8z8Nz6JwlMjTvKfDYGORecWow+C/bO9nH5+Vt7VdyLKxTOs+0uBgzr1 jr19RYr/1pfwqZ5Z2wdtV3nnKnKYg7w9JAX0wbxuY474AL8JJY/aZCKaokeY/YQxHht7 VyWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=kSvkGnY39j+b/0rwijvIf5YEcBtWpgBAqWZ+KBD9Cbc=; b=TdqbzGVdgn195DlaOcpJdKI3qPGd4YGzBr/5QrTSlWYnWALDlGynwuVw9bTnJivGXu ZoJevOzT4GwYy7wdGbbBzF1hLSbEOQ90cyOwQ6QGxXHcobvOgft+yHM2CVYsKbNP3ewB pm/irjkeYPtIhW7DX08J9TMe28dO5JUmwHiOcEZB6LFcM4IUucbAhUjkUnSo/57iFVMK WR5ZNuSEvd4xJL+CuHHR8XUDlDwTIZ/lMk/e9QeGI5OYax2mElEG4dyUa1lGm/Cv0vzk po6aqGDbemU6MH6CJXDq6oQg4FcWkSnsisZJErFSZRRoTj6dzfUMC7ACUz/68Ngp6Peq UeXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GMmYP0Rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd15si7709196ejb.606.2020.07.28.13.02.51; Tue, 28 Jul 2020 13:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GMmYP0Rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732318AbgG1S05 (ORCPT + 99 others); Tue, 28 Jul 2020 14:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728401AbgG1S04 (ORCPT ); Tue, 28 Jul 2020 14:26:56 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF1E7C061794 for ; Tue, 28 Jul 2020 11:26:56 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id l2so5090421pff.0 for ; Tue, 28 Jul 2020 11:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kSvkGnY39j+b/0rwijvIf5YEcBtWpgBAqWZ+KBD9Cbc=; b=GMmYP0Rg9FH9f0uUhlwiH6FtHWwf6NDAbaY+Mq93TUGr/l0MwZOsXegtNqGqVWFsoR KPRM1NCeM8HSZls34xf5bNr//OGARUaDzV1ReFuNpBVmuHcjhox2x44ltRwjky3kkcBM KUMBKfk1GinpjvTvsl6tY24qF+qY77+uXXd5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kSvkGnY39j+b/0rwijvIf5YEcBtWpgBAqWZ+KBD9Cbc=; b=kxcEuHXja94fMpz+/brIkYxKR7ZVmAxr9/a5bMxum+pT3aMeObgHKZXRqiB8jpYAs5 afmgVwb5dTo7W0L24n1FrYiInp1UPbutrUJxhCwwyEIFPIDXNPSqBinMnSqNINEHXFQz KvpZkZPwLY6wbqemhYo1Ehcish/R0GT1KfZ0qO3q9fzX2ptvhYIwi4xehEwCKh71LuRO nEOquJGDFsCESzuWzAVI7uvqfHMaLSAlo/iwq8AooB4TgHKpu1dNifukcrpuiKNoYmRm O0fABh6wMC35rrQiZcq1SXppnyoAlVcpqjWmdmlKhwOGp/Tz1EMHszGw7BFIB5/ZLapi KRoA== X-Gm-Message-State: AOAM532JVGJvkUexBiL8Fk9pwYYaLZsshCWcMbG53sJBNseVL6YwNHPU cijdICaFkDJJRcZup0hcxD+7Ag== X-Received: by 2002:aa7:82d5:: with SMTP id f21mr6544716pfn.222.1595960816373; Tue, 28 Jul 2020 11:26:56 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d29sm18147721pgb.54.2020.07.28.11.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 11:26:55 -0700 (PDT) Date: Tue, 28 Jul 2020 11:26:54 -0700 From: Kees Cook To: Arvind Sankar Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/8] x86/kaslr: Remove bogus warning and unnecessary goto Message-ID: <202007281126.A1AD5DE02@keescook> References: <20200727215047.3341098-1-nivedita@alum.mit.edu> <20200727230801.3468620-3-nivedita@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200727230801.3468620-3-nivedita@alum.mit.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 07:07:55PM -0400, Arvind Sankar wrote: > Drop the warning on seeing "--" in handle_mem_options. This will trigger > whenever one of the memory options is present in the command line > together with "--", but there's no problem if that is the case. > > Replace goto with break. > > Signed-off-by: Arvind Sankar Reviewed-by: Kees Cook -- Kees Cook