Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: oYMgtKw7WgQxnshU1GNf4kwnMLpNCn0XkXiM6d43LFwgbHwPMIub4xSxvcS0VLgePv2QCz8iIa
 VW3NFTBXQ+/A==
IronPort-SDR: GDgLdRPeToXtmqek9PW4+XwtLwt371zb5zT43jdHLEP6G6Lw3Ux25ZWb+bY/66WxbggDbwWWmT
 JfdQ1P5urrlg==
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [char-misc-next V2] mei: add device kind to sysfs
Thread-Topic: [char-misc-next V2] mei: add device kind to sysfs
Thread-Index: AQHWZQzsP7MTlAgR70GuvAbRthg4rqkdJAuAgAA4N3A=
Date:   Tue, 28 Jul 2020 19:16:55 +0000
Message-ID: <8a88b1db0b9447ebaa37636a68e3b018@intel.com>
References: <20200728182836.3112138-1-tomas.winkler@intel.com>
 <20200728185219.GA332869@kroah.com>
In-Reply-To: <20200728185219.GA332869@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> 
> On Tue, Jul 28, 2020 at 09:28:36PM +0300, Tomas Winkler wrote:
> > +/**
> > + * kind_show - display device kind
> > + *
> > + * @device: device pointer
> > + * @attr: attribute pointer
> > + * @buf: char out buffer
> > + *
> > + * Return: number of the bytes printed into buf or error
> 
> No need for kernel doc for static sysfs attributes, but ok...
> 
> > + */
> > +static ssize_t kind_show(struct device *device,
> > +			 struct device_attribute *attr, char *buf) {
> > +	struct mei_device *dev = dev_get_drvdata(device);
> > +	ssize_t ret = 0;
> 
> No need to initialize this.
Right, a leftover from an earlier version. 
> 
> > +
> > +	mutex_lock(&dev->device_lock);
> > +	if (dev->kind)
> > +		ret = sprintf(buf, "%s\n", dev->kind);
> > +	else
> > +		ret = sprintf(buf, "%s\n", "mei");
> > +	mutex_unlock(&dev->device_lock);
> 
> Why do you need a lock?  kind can not change, so what are you trying to
> protect from?
There might be firmware initiated reset but in this particular case you are right,  the lock is not needed.

Will resend.