Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp571070ybg; Tue, 28 Jul 2020 13:05:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyiJJ0wSDVPBAxlgzLhXngJRpEqz2eIDai8w/SQtyU6HDQnes4VFkA6VsA60lsAPI6RySc X-Received: by 2002:a17:906:3b01:: with SMTP id g1mr28142957ejf.353.1595966754339; Tue, 28 Jul 2020 13:05:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595966754; cv=none; d=google.com; s=arc-20160816; b=lcSVYwCBEi9QJs0AEmb4RS9Ei/z5O2LOAGqxa1n/GVQK0n1w73vMgoGwlmnCcNgw77 65puuNHj6ap6lMuqpcyj1RPHUwgJ1k7HCOZOfPH3AfepvopkPNaIB0H4Oc//yn0TfWCn IaPrTj4YiIcBl6HCOrRjCATQ7w3/O7ajt13SPci9AuFVT1STg+yHEvkcFsXhDydVIZ40 S2QAPYbzXQQCkRYBK9pgMEN0ZJB31iZBVv8uvvGYDxhGSgMWPXVnC9/d68UcEsIYDsbj pq2tS36sNNjcIZOGJBT9WhY2+pQvmajLk5EDX5SnKasVXfvmaeO1mQFvPnM+5PPmGTz8 /tUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LShjUHe55qHr9R54MiC4pJLtdunf62y5cwJnoLIJjrc=; b=QbpNWQp9hIutYLxwe8/4xo63oNj+G39j98CtS36giotwdtBUKYfSZyXbFczHhO0pn3 apzJcmHGzW3kD/aYWXeLuAvl23jMHsna3Mr58hlskbHRKvrcymM9zJRzRgtjVC60ZjdY w5YOnqtYCqKq0r3OAgBrXvxhoBw146szVBMaD+CB43nA7+aII/sS5K/WOax3vh2PieZk yfFwbG/194sd6jSbsx7uYMe288NX+XJD2Kx0zy263LU4B+hv4X5MZspULuEpTNY2nCAG EcxUF6zQi5hq69VW/DkaDI1vLU2+/sq2VteqhVAkMZK3XzmmwtHm3ujgaKWCHbstI/Pt ZTnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si1091982edt.444.2020.07.28.13.05.32; Tue, 28 Jul 2020 13:05:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbgG1UCp (ORCPT + 99 others); Tue, 28 Jul 2020 16:02:45 -0400 Received: from netrider.rowland.org ([192.131.102.5]:58183 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728050AbgG1UCp (ORCPT ); Tue, 28 Jul 2020 16:02:45 -0400 Received: (qmail 1512022 invoked by uid 1000); 28 Jul 2020 16:02:43 -0400 Date: Tue, 28 Jul 2020 16:02:43 -0400 From: Alan Stern To: Martin Kepplinger Cc: Bart Van Assche , jejb@linux.ibm.com, Can Guo , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@puri.sm Subject: Re: [PATCH] scsi: sd: add runtime pm to open / release Message-ID: <20200728200243.GA1511887@rowland.harvard.edu> References: <20200706164135.GE704149@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 09:02:44AM +0200, Martin Kepplinger wrote: > Hi Alan, > > Any API cleanup is of course welcome. I just wanted to remind you that > the underlying problem: broken block device runtime pm. Your initial > proposed fix "almost" did it and mounting works but during file access, > it still just looks like a runtime_resume is missing somewhere. Well, I have tested that proposed fix several times, and on my system it's working perfectly. When I stop accessing a drive it autosuspends, and when I access it again it gets resumed and works -- as you would expect. > As we need to have that working at some point, I might look into it, but > someone who has experience in the block layer can surely do it more > efficiently. I suspect that any problems you still face are caused by something else. Alan Stern