Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp572274ybg; Tue, 28 Jul 2020 13:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfC4jUuxPXfKumIYgV5sOCRJxTSFGXQl/FvI1Tq1Qci04gvT46Qdk+vSvs5jVPhhpqRp9u X-Received: by 2002:a50:bf09:: with SMTP id f9mr27240092edk.249.1595966855980; Tue, 28 Jul 2020 13:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595966855; cv=none; d=google.com; s=arc-20160816; b=zw/xGl+mrQ2gpH91z1pL7jV6Er3+Yclki8hNa59L8NqwnhkbiJ6ynUzrqI+u3c3ZNp 7HpdhFHqCLo6qR3K89C/OP2sR8BewpCNdjGMVfJs6po/Tq4oaJ/OO5BmmIbxWKQZKsdr aPM0a6Q4XkzX8fsH8LHbx4v7A7EqMmF/VM00f+OEpRKqvbHxqGZDA6Grei9evInSlFfe BtZjKFjYwr0yfapH1rJEgGMY/oSOGtC79ueWmi4K7LS6XkC49jaYhDQkyv1nr7Lc/KUj slhbFvhrTttRKFb2fM2IkR3VWh4wk93nHebC6yPcbDVcwOu37Jxv2lfdSu2s+5EYCfNo Mhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=jwkgF4tNm70DYIHHRtKD5PUpPWtPSOLsVKK5ldqlxrA=; b=m7GHD/suM73/3zB10hIMghOmRj7mhkMd+AzRPdP+Aftmc0NNviLq5nK6AO8VM1vdQO gYs6sTnf2iakMD3Jtc7hpJkfgIiKkLlg86Vu4Pj7N1jr8G+MbWlHPcOIHKtjgud4JP0e cGdqFfjfRzySvTZkSAFywwqnlHb4kA/3CdbZT2ItRq0sEMTIixAlPLKhGnvk9XZMBiG1 M9eSbywbBYYM8aSWQXHInSc6RxeFyEPePvY+k6Atjdjan7p2KOZm5qGbHnb3A6RSOHBN Kds2AI34cxT4uGMUJuj4PhE1Qee8kmVzfZB1qIrUPRt5CKBzxOg+dW4GXxLmhNr35tUI gxzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d24si4177148edz.145.2020.07.28.13.07.13; Tue, 28 Jul 2020 13:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbgG1T5F (ORCPT + 99 others); Tue, 28 Jul 2020 15:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728939AbgG1T5F (ORCPT ); Tue, 28 Jul 2020 15:57:05 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D047C061794; Tue, 28 Jul 2020 12:57:05 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5C0A6128A1DBC; Tue, 28 Jul 2020 12:40:19 -0700 (PDT) Date: Tue, 28 Jul 2020 12:57:03 -0700 (PDT) Message-Id: <20200728.125703.1154756600985752474.davem@davemloft.net> To: vaibhavgupta40@gmail.com Cc: helgaas@kernel.org, bhelgaas@google.com, bjorn@helgaas.com, vaibhav.varodek@gmail.com, kuba@kernel.org, kevin.curtis@farsite.co.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH v1] farsync: use generic power management From: David Miller In-Reply-To: <20200728042809.91436-1-vaibhavgupta40@gmail.com> References: <20200728042809.91436-1-vaibhavgupta40@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Jul 2020 12:40:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vaibhav Gupta Date: Tue, 28 Jul 2020 09:58:10 +0530 > The .suspend() and .resume() callbacks are not defined for this driver. > Still, their power management structure follows the legacy framework. To > bring it under the generic framework, simply remove the binding of > callbacks from "struct pci_driver". > > Change code indentation from space to tab in "struct pci_driver". > > Signed-off-by: Vaibhav Gupta Applied.