Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp572481ybg; Tue, 28 Jul 2020 13:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm5E4VUzzhfZwf77Y0a2akZmvgaxWUB/IEJXw+KYX1ZxVSTyqCPZKbd9i3a5zjG2RicRrS X-Received: by 2002:a17:906:4f82:: with SMTP id o2mr27874379eju.424.1595966873972; Tue, 28 Jul 2020 13:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595966873; cv=none; d=google.com; s=arc-20160816; b=AGwVHBcFxzJiqe64gPFfev5S1t7bYsjV3xTJSIwMdZOCBbgSwmR5Ml0kG0I8N+6tnK FxZNjqogSk6Q/u5UL+reJS1GZReEyOdib7QFQchuYSUiq18yyuEqRaPnTlppc39ot8GQ 7jFuLoxx5O3imBzOJQqAlGAgf1sDTACoz0a8tFvs0ORjKa5AD4uSxY0adM9XLaiw/c9E Ss/OeiDSKMxxHmslo4LzlthMuAIeU//Au1+Lugd90zfDeNesXuIljaV+wLx1RIVeHNM2 3aDY34YEtAqTukFKRghnBYGQOvGfR/eYBRlUNcKhP7KDokzyvWbRgLgaQvCTfJUPssLu kYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=PZOHerfZSI75ytj0dphp/gnBmvV2HWUdolaX4utU4Oo=; b=eqAt0tJ1IGmgpR3U4FcSU+Rz3ZUWxBjyqJMY14KTvOm3kSTTkI0MphJvIMi5hxGciM 6K5zON1Vv5mf0jPvzF6YgudHTpsBHnwlWkMI8bbF3TZglqHDS4JCp2GsLJYJNC0z0Lfj oxgU+A0q1bEAOdg17rtEATj5KB2Frtg2Zky7eE0b5p5Iu4pMcXHwaekWumBCCRnCO2Ej c119R4HiyeF6ZD7msRnZY88MtepZwQZL1PeNkX1jOHtrtyDUy9PTECs5AjuGSTysYpnJ xmr/SuaRcBez09HEPC6o7XuptnGgMd49TJzXPMvKEFi7/tjZJ9Z7WbxyFSAA20fP5Mrf EGbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si6426436edf.434.2020.07.28.13.07.31; Tue, 28 Jul 2020 13:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbgG1UCc (ORCPT + 99 others); Tue, 28 Jul 2020 16:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728175AbgG1UCb (ORCPT ); Tue, 28 Jul 2020 16:02:31 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9F62C061794; Tue, 28 Jul 2020 13:02:31 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1F85F128A4D86; Tue, 28 Jul 2020 12:45:46 -0700 (PDT) Date: Tue, 28 Jul 2020 13:02:30 -0700 (PDT) Message-Id: <20200728.130230.969755460801493655.davem@davemloft.net> To: rkovhaev@gmail.com Cc: kuba@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: hso: check for return value in hso_serial_common_create() From: David Miller In-Reply-To: <20200728064214.572158-1-rkovhaev@gmail.com> References: <20200728064214.572158-1-rkovhaev@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Jul 2020 12:45:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rustam Kovhaev Date: Mon, 27 Jul 2020 23:42:17 -0700 > in case of an error tty_register_device_attr() returns ERR_PTR(), > add IS_ERR() check > > Reported-and-tested-by: syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com > Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d0321e > Signed-off-by: Rustam Kovhaev Applied, thank you.