Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 12i0FLLbsKJXDPq6vbkAS7xTbuBjU+hWHXoXdX+Ml9zy2suBTL6MOcdWIfCoF0LENPhyS1dhWc
 hVAXG1p8PRKg==
IronPort-SDR: miVU2I0McXErxbxijod2t2SN2xn3F3lgq+8cASjW/oF5LcnlQ0DQUBwiwTOI+FgVowb1QRWzQD
 /vCancc/U8XA==
From:   "Brown, Aaron F" <aaron.f.brown@intel.com>
To:     Aaron Ma <aaron.ma@canonical.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
        "kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>,
        "Neftin, Sasha" <sasha.neftin@intel.com>
Subject: RE: [Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even
 when failed to disable ULP
Thread-Topic: [Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even
 when failed to disable ULP
Thread-Index: AQHWQ8XCGt1Zf2BsuE6OIRiqVZ8UlKjd8zCAgD/B2cA=
Date:   Tue, 28 Jul 2020 20:34:41 +0000
Message-ID: <DM6PR11MB2890F94DA893CE56A5D8A3EABC730@DM6PR11MB2890.namprd11.prod.outlook.com>
References: <20200616100512.22512-1-aaron.ma@canonical.com>
 <20200618065453.12140-1-aaron.ma@canonical.com>
In-Reply-To: <20200618065453.12140-1-aaron.ma@canonical.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 02e08b5c-3ae4-49cd-4571-08d83335a816
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2020 20:34:41.8440
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J9RVJEfLV/xiYohTy1pBzxzx+n/6XZw4u7PjwJgsaU0iJIfqbvf784Dy0ionNWL/hW5SWT0uWgKPxu3K2kZYEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4377
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Aaron Ma
> Sent: Wednesday, June 17, 2020 11:55 PM
> To: kuba@kernel.org; Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>;
> davem@davemloft.net; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lifshits, Vitaly
> <vitaly.lifshits@intel.com>; kai.heng.feng@canonical.com; Neftin, Sasha
> <sasha.neftin@intel.com>
> Subject: [Intel-wired-lan] [v4][PATCH] e1000e: continue to init phy even =
when
> failed to disable ULP
>=20
> After 'commit e086ba2fccda4 ("e1000e: disable s0ix entry and exit flows
>  for ME systems")',
> ThinkPad P14s always failed to disable ULP by ME.
> 'commit 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")'
> break out of init phy:
>=20
> error log:
> [   42.364753] e1000e 0000:00:1f.6 enp0s31f6: Failed to disable ULP
> [   42.524626] e1000e 0000:00:1f.6 enp0s31f6: PHY Wakeup cause - Unicast
> Packet
> [   42.822476] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
>=20
> When disable s0ix, E1000_FWSM_ULP_CFG_DONE will never be 1.
> If continue to init phy like before, it can work as before.
> iperf test result good too.
>=20
> Fixes: 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -
>  1 file changed, 1 deletion(-)

I never did find a system that triggered the initial problem, but from a co=
mpatibility with the set of systems I do have working...
Tested-by: Aaron Brown <aaron.f.brown@intel.com>