Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp704262ybg; Tue, 28 Jul 2020 17:10:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaWf3wYEyb2nOW5cHbE2Q+QD1U0u53C9d9ACO6OnkdOVG2IEtflhxqZNCJWF7V2l2O8lM/ X-Received: by 2002:a17:906:4685:: with SMTP id a5mr27600697ejr.46.1595981452284; Tue, 28 Jul 2020 17:10:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595981452; cv=none; d=google.com; s=arc-20160816; b=SxPIT4q3b+Hp/8L4Cr7S3GzzzrJlnUC38URRwytFroQcSD/DMhZFq7cEfOE4wtftri 03RUecjrlnsSCvaIVg03O70nb4deTpt9qGgSZcmCuGocbMNiK0Ngct61NTGE8BqwqEuC YpCa7EmuI09aQRKmFZwr6nbgdJu2k9niNWpI1281oxTWDqM3QlYIIPAAe7CVX3IBQzpq q7Nc+1C0KF1eN6zLARo266XiZCmzenaUn2H5IBNbhh+OcRSHKxMjGjgdPgB7BjzXNvcx Xh5qto3G3msXbqu0D7PMzHjNXoD16qQPhWVJszMaTo9b5wN2ytSivkzFotUmKz/8s/E4 O/Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NIt8V+0Ly8zCDHiK1shQ9ILtxkb0CmTmo030ThJYXRc=; b=wQrXzd/WysbnVht1zBbSKknyUTwrn4Bu21ydDjGqrxfiS413rFwvaOmTv1OZmrcbdY NrqKtHvwXXffVCyMrZB73wyLbLLfjFSqcB7XUvG/EAllGFOOaoqe8GN//bisWmGKgZzZ 87o5yD91/aWou4XTj55Uk5W+sfTttw7gL0U0dT+IyvnsdG8v1HyOTlBRXAc6E9JCFwjL ++qlagk6p3Xysa6phQxOHvAVir9gfwsZHTFG7aLiziv4I5EgwW5iVoA/7xbhrKxNx62b bBltAtuOlv7doYh8T7TH3HLIr/JVV/IKINwBcncJDNLz16n01ythKG9+13cAw/boqvSF c4wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=At1MN+Fz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si29582ejj.386.2020.07.28.17.10.30; Tue, 28 Jul 2020 17:10:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=At1MN+Fz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbgG2AJ6 (ORCPT + 99 others); Tue, 28 Jul 2020 20:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730219AbgG2AJ6 (ORCPT ); Tue, 28 Jul 2020 20:09:58 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBCB5C0619D2 for ; Tue, 28 Jul 2020 17:09:57 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id z3so7612797ilh.3 for ; Tue, 28 Jul 2020 17:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NIt8V+0Ly8zCDHiK1shQ9ILtxkb0CmTmo030ThJYXRc=; b=At1MN+FzIe1tFpSFrYfVBPnrEMgocxF1GxQ6l661JXfQUSL09B22WGVDFknoRIDEIf tRG+xOoU3FZZZMnJGjfuPFPl8E3+qbBa1Vlm4WmIsAbjoTRHML/YfD3T/yXLluhZFamt 03u7pLSnNw9w6hrsyoPycGKgrdJ8a0GfGb+EJqEpgT61mXDlTtQoyLi6YAldXQP6hk2d BEHoVxL9MInXNDCyKtRve/qoG6kRFZAXukmBRrpkKEederyrHc1E92VdClFR/zAuOXzL H82qr89vU69GvNOybrP5Hr/3yHj9zyTZjsAPIr9a735oJjC5eCGbhb+/saHV//RnJXPj cvpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NIt8V+0Ly8zCDHiK1shQ9ILtxkb0CmTmo030ThJYXRc=; b=VM+2/ylcbuNiAMXp9hGX3H5Sw5tX5Djo4S5xJaEE71gXxlOX2RdvjUguirvWdgxUFX ZQLR73c1k2AMxQVJMvEK6wRcSDwWXEvLu5J+3d9aEbTZZoVGcw/QBRpEa0zJEZAv56Ns H3a947OeG1lH6tOzrq8bnR4rG6Bj7B7fj2zCbEp2gkgY1Hp0sPHBUBNwV8+Tuh4ZduTO 9ZfwLblgO1dMyCbIVSdtLGxJHnmfdfaBnYytbLbVu4nkS7MxsLyyQ+mV+JEdhfMvMU5p L15k2GZbMnDql1h0+82MEcypKt8zGPY4wTMT1JrxFA+N2RLeD4avCSvfck2jwHzeCWp4 KV8Q== X-Gm-Message-State: AOAM5337+S5sfrAKAW1ETUiqlCkKWV8oSgx2tfjlpAW1CA9DEyr2n6rJ gU1fPa4m1K9/Q/hnFJUjzR15lIx8HLXv5hUPEy4pLg== X-Received: by 2002:a92:790d:: with SMTP id u13mr25673361ilc.26.1595981396870; Tue, 28 Jul 2020 17:09:56 -0700 (PDT) MIME-Version: 1.0 References: <159597929496.12744.14654593948763926416.stgit@bmoger-ubuntu> In-Reply-To: <159597929496.12744.14654593948763926416.stgit@bmoger-ubuntu> From: Jim Mattson Date: Tue, 28 Jul 2020 17:09:46 -0700 Message-ID: Subject: Re: [PATCH v3 00/11] SVM cleanup and INVPCID support for the AMD guests To: Babu Moger Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Sean Christopherson , kvm list , Joerg Roedel , "the arch/x86 maintainers" , LKML , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 4:37 PM Babu Moger wrote: > > The following series adds the support for PCID/INVPCID on AMD guests. > While doing it re-structured the vmcb_control_area data structure to > combine all the intercept vectors into one 32 bit array. Makes it easy > for future additions. > > INVPCID interceptions are added only when the guest is running with > shadow page table enabled. In this case the hypervisor needs to handle > the tlbflush based on the type of invpcid instruction. > > For the guests with nested page table (NPT) support, the INVPCID feature > works as running it natively. KVM does not need to do any special handlin= g. > > AMD documentation for INVPCID feature is available at "AMD64 Architecture > Programmer=E2=80=99s Manual Volume 2: System Programming, Pub. 24593 Rev.= 3.34(or later)" > > The documentation can be obtained at the links below: > Link: https://www.amd.com/system/files/TechDocs/24593.pdf > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D206537 Very nice cleanup. Thanks for doing this!