Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Jul 2020 02:28:01 +0200
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver
To:     daniel@ffwll.ch
Cc:     David Airlie <airlied@linux.ie>, od@zcrc.me,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Message-Id: <PYF7EQ.CC652MXUV2R41@crapouillou.net>
In-Reply-To: <20200728220008.GI6419@phenom.ffwll.local>
References: <20200728151641.26124-1-paul@crapouillou.net>
        <20200728201736.GA1277651@ravnborg.org>
        <20200728220008.GI6419@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le mer. 29 juil. 2020 =E0 0:00, daniel@ffwll.ch a =E9crit :
> On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote:
>>  Hi Paul.
>>=20
>>  On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
>>  > Here are a few cleanups to the ingenic-drm driver.
>>  > - some error paths were missing and have been added;
>>  > - the mode validation has been moved to the .mode_valid helper=20
>> callback.
>>  >
>>  > Cheers,
>>  > -Paul
>>  >
>>  > Paul Cercueil (2):
>>  >   drm/ingenic: Handle errors of drm_atomic_get_plane_state
>>  >   drm/ingenic: Validate mode in a .mode_valid callback
>>=20
>>  Both looks fine, you can add my:
>>  Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>>=20
>>  I assume you will apply the patches.
>>  Maybe wait for Daniel to take a look, he had some feedback on where
>>  to add checks. I assume this is covered by the second patch.
>=20
> Yeah changelog for new versions would be great, but aside from that
> bickering patch 2 lgtm now.

This patchset is V1, I'm fixing issues you saw in the ingenic-drm=20
driver when reviewing a different patchset.

Thanks for the review, I'll apply now.

-Paul
>=20