Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Jul 2020 09:28:21 +0800
From:   Boqun Feng <boqun.feng@gmail.com>
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        "Paul E. McKenney" <paulmck@kernel.org>, rcu <rcu@vger.kernel.org>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH RFC v2] rcu/segcblist: Add counters to segcblist
 datastructure
Message-ID: <20200729012821.GA136701@tardis>
References: <20200719035518.2386828-1-joel@joelfernandes.org>
 <CAEXW_YQhYiYQZOJ95dqBcu_fAZ_6k7HGbrw53eTgPrgXU+5few@mail.gmail.com>
 <20200719041841.GA2398236@google.com>
 <20200720082211.GA35358@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net>
 <CAEXW_YR4dxuPV+Yu9HcYCSAdiV1H=9Rk9HJgCST-YMMc7J2Mgg@mail.gmail.com>
 <20200727134925.GB79404@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net>
 <20200727230323.GA3390623@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG"
Content-Disposition: inline
In-Reply-To: <20200727230323.GA3390623@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 27, 2020 at 07:03:23PM -0400, Joel Fernandes wrote:
> On Mon, Jul 27, 2020 at 09:49:25PM +0800, Boqun Feng wrote:
> [...]=20
> > So C11 features are available to gnu89 as extensions, also I tried to
> > compile the following code with -std=3Dgnu89:
> >=20
> > 	#include <stdio.h>
> >=20
> > 	typedef struct {
> > 		int a;
> > 	} atomic_t;
> >=20
> > 	void g(void) {
> > 		printf("this is g\n");
> > 	}
> >=20
> > 	void h(void) {
> > 		printf("this is f\n");
> > 	}
> >=20
> > 	#define gen(x) _Generic((x), atomic_t : h(), int : g())
> >=20
> > 	int main(void) {
> > 		int a;
> > 		atomic_t b;
> > 		gen(a);
> > 		gen(b);
> > 		gen(b);
> > 	}
> >=20
> > , and it worked.
> >=20
> > Besides, please note that in include/linux/compiler_types.h, _Generic is
> > already used.
>=20
> > > > With these primitives introduced, you can avoid () to add those
> > > > rcu_segcblist_*_seglen() which have #ifdefs in them. Of course, an
> > > > alternative would be that we implement rcu_segcblist_*_seglen() usi=
ng
> > > > _Generic, but I think someone else may have the similar problems or
> > > > requirement (already or in the future), so it might be worthwhile to
> > > > introduce the gen_ primitives for broader usage.
> > >=20
> > > One issue is code using memory barriers around the operation, such as
> > > in rcu_segcblist_add_len() where you use smp_mb__before_atomic() for
> > > the atomic version, and regular smp_mb() for the non-atomic version.
> > > So ifdef will still exist to some degree.
> > >=20
> >=20
> > Right, I think we can have two functions: long_add_mb() and
> > atomic_long_add_mb(), this part is similar to ifdef approach, but we can
> > make a gen_long_add_mb() based on these two functions, and
> > gen_long_add_mb() simply switches between those functions according to
> > the actual type of the field, which I think is better than ifdef
> > approach at readability and maintenance.
>=20
> Thanks for clarification. I agree with your idea, would you be able to wr=
ite
> a patch to add the helpers my patch can use?
>=20

Sure, I will send a prototype to see others' feelings about this, will
try to get that done by a day or two, so hopefully it won't block your
work ;-)

Regards,
Boqun

> If others are Ok with your idea, I can go ahead and use your helpers.
>=20
> (I could write the helpers myself as well, next time I send the patch).
>=20
> thanks,
>=20
>  - Joel
>=20

--OgqxwSJOaUobr8KG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEj5IosQTPz8XU1wRHSXnow7UH+rgFAl8g0K8ACgkQSXnow7UH
+rg2mAgArvrSA66zszPpnXs/12qdRJQHheaRydnJj6wGjkfE8IfgERXE45Qdlu1W
aeZ2KcjEv8LZHEdK6TU8MgFvEC5TDiUi4mc6YYRBNCN9A4ebDP1QWIjLW5K4RUAy
5ET4TIowJX7uJ61uCidcjTxqnrFB11Ro5laETYffavcEkMkCjUkz06GcR2SYB6dn
9CgSz68RllKVDmu9UI0Gn/z3Q8UBErFLg1e92jHLviYUM2o2IqDHo7TRVhnFKXPC
QAawhkfayzY4Qvhg0vsQ4hyP76uyVHBQSnJKs/3jWJBJWrYAajYWgat8TW5HvjOp
PTKzFNV5kdmUxgea5FP+kZLMAgHK6g==
=ZCh6
-----END PGP SIGNATURE-----

--OgqxwSJOaUobr8KG--