Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE9CBC433C6
Subject: Re: [PATCH V2] dt-bindings: pci: convert QCOM pci bindings to YAML
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        PCI <linux-pci@vger.kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1595776013-12877-1-git-send-email-sivaprak@qti.qualcomm.com>
 <CAL_Jsq+-rwG73mEkYmMQcnxHoBpbFMWHKDvzUK=6-fMAo77-9w@mail.gmail.com>
 <CAL_JsqJU81U5CNSia3Lrzwb2VpPy3YMK=tJfXgU49TuGn1eRyQ@mail.gmail.com>
From:   Sivaprakash Murugesan <sivaprak@codeaurora.org>
Message-ID: <fcb3df88-18bd-add1-5329-92af92948048@codeaurora.org>
Date:   Wed, 29 Jul 2020 08:19:06 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAL_JsqJU81U5CNSia3Lrzwb2VpPy3YMK=tJfXgU49TuGn1eRyQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

On 7/28/2020 9:24 PM, Rob Herring wrote:
> On Tue, Jul 28, 2020 at 9:27 AM Rob Herring <robh+dt@kernel.org> wrote:
>> On Sun, Jul 26, 2020 at 9:07 AM Sivaprakash Murugesan
>> <sivaprak@qti.qualcomm.com> wrote:
>>> From: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>>
>>> Convert QCOM pci bindings to YAML schema
>>>
>>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>> ---
>>> [v2]
>>>    - Referenced pci-bus.yaml
>>>    - removed duplicate properties already referenced by pci-bus.yaml
>>>    - Addressed comments from Rob
>>>   .../devicetree/bindings/pci/qcom,pcie.txt          | 330 ---------------
>>>   .../devicetree/bindings/pci/qcom,pcie.yaml         | 447 +++++++++++++++++++++
>>>   2 files changed, 447 insertions(+), 330 deletions(-)
>>>   delete mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>>   create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> new file mode 100644
>>> index 000000000000..ddb84f49ac1c
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>> @@ -0,0 +1,447 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +
>>> +%YAML 1.2
>>> +---
>>> +$id: "http://devicetree.org/schemas/pci/qcom,pcie.yaml#"
>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>> +
>>> +title: Qualcomm PCI express root complex
>>> +
>>> +maintainers:
>>> +  - Sivaprakash Murugesan <sivaprak@codeaurora.org>
>>> +
>>> +description:
>>> +  QCOM PCIe controller uses Designware IP with Qualcomm specific hardware
>>> +  wrappers.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - qcom,pcie-apq8064
>>> +      - qcom,pcie-apq8084
>>> +      - qcom,pcie-ipq4019
>>> +      - qcom,pcie-ipq8064
>>> +      - qcom,pcie-ipq8074
>>> +      - qcom,pcie-msm8996
>>> +      - qcom,pcie-qcs404
>>> +      - qcom,pcie-sdm845
>>> +
>>> +  reg:
>>> +    description: Register ranges as listed in the reg-names property
>> Can drop this.
>>
>>> +    maxItems: 4
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: dbi
>>> +      - const: elbi
>>> +      - const: parf
>>> +      - const: config
>>> +
>>> +  ranges:
>>> +    maxItems: 2
>>> +
>>> +  interrupts:
>>> +    items:
>>> +      - description: MSI interrupts
>>> +
>>> +  interrupt-names:
>>> +    const: msi
>>> +
>>> +  "#interrupt-cells":
>> In pci-bus.yaml, so you can drop.

I am getting the below error if I remove #interrupt-cells alone.

properties: '#interrupt-cells' is a dependency of 'interrupt-map'

interrupt-map is also documented in pci-bus.yaml hence dropping that as 
well.