Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp890142ybg; Tue, 28 Jul 2020 23:47:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo6qH+R6eWxml8+XtnQFdcweET17t2SgffKClijXxWNp6BhNeN1E7r5cx8Rxq2/YKfh/oq X-Received: by 2002:a50:e047:: with SMTP id g7mr28815182edl.290.1596005266109; Tue, 28 Jul 2020 23:47:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596005266; cv=none; d=google.com; s=arc-20160816; b=poXaA50aKsaHJHYpLvB3weJIDTEqHQRstPChq49WW50kVtsSlu0N+bddvuLlPOQsZp BtuYTtI503pEcpxLxhWTEMzRVSjwfLVfxNDK+vjjtrwILyU5kvplaXh2cyyVDMl+MuaU 2flNEu68pAVL8GB2ABYRqNp/l0QDWlQ5CUNimpivFByb3bLRQAK48VgDzcyAF40ufoHR sjxlEzWWwcFj/xVuDAZT9QyCIFaTri8e5EXn7u52mVhVuMEfoGKtZ5GY7eyzGAIBh/w4 65LsCy/JGGEdxV8E1eGTddUlV6Y/agPcUWjUBcX+1xq4HO1NTQvmCLMtWynMDlrVEEX+ wRcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=F8Dx2k2QTTUlJ3PVcw289iUoRDVJ4gqpdkDJN4dKpe8=; b=SeaprhJoHcAs6qcBMg8kGLPxBtcksRbFGYRUSUn7Cj75JDrw0FFqIwzyq7GWJDJ/do 9/gppmXz8CMLGIltnuaJ8hWn5qYSwoHTVOQZJngtZ9yJoYiPF4pXGRmqbNhPcpsrHLT0 ZkyrxdtK3pPa4ZhuCFvq7XVXsSs2AAbFIpnV4teg7nQP+1vb5bmUNtZve/Sh8gn747zH 05J0CNP7gN8X3dTJv9ImuYQgKntZe006CeUFsjkMxy1vxBsf+PI0axRuhs9b3zfL4dwR csBwViDcDB5DELdacodVMla5Nd8l+94rmhDh7OfDs6UniEEl4BKBn/FHDkLdwwOGGZ09 pz4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="ubn/W4qS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rl3si496277ejb.643.2020.07.28.23.47.23; Tue, 28 Jul 2020 23:47:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="ubn/W4qS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgG2Gp1 (ORCPT + 99 others); Wed, 29 Jul 2020 02:45:27 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:55647 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgG2Gp0 (ORCPT ); Wed, 29 Jul 2020 02:45:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596005126; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=F8Dx2k2QTTUlJ3PVcw289iUoRDVJ4gqpdkDJN4dKpe8=; b=ubn/W4qSOoZRRteYWukQtEwAfTssbHgYgRt0KsEiGUdJ861GpZzIKPpoMTIMOxANBw9QuyJR ca0WbgMGZesA7jI6LVpCqHL3zboJAD+IXspMdDeIgQs9+9HHEzxhq/C5X40odYhWAXXxrjhO P295fWPYzGuX1cRBQ76z9sbMNH0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f211b0570ff737ddbb67b23 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Jul 2020 06:45:25 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6D9EDC4339C; Wed, 29 Jul 2020 06:45:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=ALL_TRUSTED,NICE_REPLY_A, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.0.101] (unknown [49.204.127.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sivaprak) by smtp.codeaurora.org (Postfix) with ESMTPSA id 232CEC433C9; Wed, 29 Jul 2020 06:45:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 232CEC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=sivaprak@codeaurora.org Subject: Re: [PATCH 5/9] phy: qcom-qmp: use correct values for ipq8074 gen2 pcie phy init To: Vinod Koul Cc: agross@kernel.org, bjorn.andersson@linaro.org, bhelgaas@google.com, robh+dt@kernel.org, kishon@ti.com, mturquette@baylibre.com, sboyd@kernel.org, svarbanov@mm-sol.com, lorenzo.pieralisi@arm.com, p.zabel@pengutronix.de, mgautam@codeaurora.org, smuthayy@codeaurora.org, varada@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, stable@vger.kernel.org, Selvam Sathappan Periakaruppan References: <1593940680-2363-1-git-send-email-sivaprak@codeaurora.org> <1593940680-2363-6-git-send-email-sivaprak@codeaurora.org> <20200713055558.GB34333@vkoul-mobl> From: Sivaprakash Murugesan Message-ID: <9988249f-53aa-e615-f64b-28c0c0641ab4@codeaurora.org> Date: Wed, 29 Jul 2020 12:15:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200713055558.GB34333@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2020 11:25 AM, Vinod Koul wrote: > On 05-07-20, 14:47, Sivaprakash Murugesan wrote: >> There were some problem in ipq8074 gen2 pcie phy init sequence, fix > Can you please describe these problems, it would help review to > understand the issues and also for future reference to you Hi Vinod, As you mentioned we are updating few register values and also adding clocks and resets. the register values are given by the Hardware team and there is some fine tuning values are provided by Hardware team for the issues we faced downstream. Also, few register values are typos for example QSERDES_RX_SIGDET_CNTRL is a rx register it was wrongly in serdes table. I will try to mention these details in next patch.