Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: x6StlzwikKWDu1MOZ0lA7CIUwNWCYDVuzr/wNV85ZLZNahD9l+LtZvUbjgZtyuLNhZqKKuMIfG
 2WEDe27GU/1TZpsA7+CFYJa8n7Myd7ChKkeeZv/2PPILyCuxG5ShNoEuPhzWQtX/yYjx2koW2R
 YPPMEELd4HF2D7IUR6QByLdCjEjJvaXs1SnpkJpU2R2biRRxPSYz7/yeiOc4v5xOMr/kPcBFF4
 3BMPWxG5wkFsd9U3ybsFDYZxCIH1VkcktLRrY9QBX0W4MmvjorpOM2WeXwQdMGGRMWIJlYsIOg
 cB0=
IronPort-SDR: 4ekXAohnQBN3XC+6/ijUyNP+u9C3mqLFYEwu/rygbCet+KCi0fDsWXEdCXsXv1zI9JcL13FrDp
 CWX6Af7fK1Vaf2LFSwvPzKJkU5gr8asQ62BplKYpTkCf+5jKFPxdnU4NCNJ2M1pgQXNFVOY7sR
 JzG90z1Lt/uxBZ4CdRGbYLZX+hHNYb9O9prWhsrXbfWZAq2URqeqxZRtdzn9TwMOrx5NMEuhsF
 SNsOtn/MWTFquS4gV8EDjbeP4Wo66qjYu+mnCzlQXdWOx37dpzX790Bs1Ez9KO766LZJ8A6RSa
 y24=
Message-ID: <33fbac338c9d9accda37837eb1338003b28cafee.camel@ew.tq-group.com>
Subject: Re: [PATCH v2] arm: dts: imx7: add QSPI
From:   Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Date:   Wed, 29 Jul 2020 09:14:55 +0200
In-Reply-To: <20200729071106.8213-1-matthias.schiffer@ew.tq-group.com>
References: <20200729071106.8213-1-matthias.schiffer@ew.tq-group.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-07-29 at 09:11 +0200, Matthias Schiffer wrote:
> In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add
> the
> QSPI controller to imx7s.dtsi.
> 
> Based-on-patch-by: Han Xu <han.xu@nxp.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> 
> v2:
> - renamed node and label
> - reordered properties
> (as suggested by Marco Felsch)

Ugh, I neglected to check for compile warnings after adjusting the node
name. This now gives the following warning:

arch/arm/boot/dts/imx7s.dtsi:1165.24-1176.6: Warning (spi_bus_bridge): 
/soc/bus@30800000/qspi@30bb0000: node name for SPI buses should be
'spi'

So I guess this should be called spi@ after all?


> 
> 
>  arch/arm/boot/dts/imx7s.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi
> b/arch/arm/boot/dts/imx7s.dtsi
> index 1cfaf410aa43..22e4c38223bd 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -1162,6 +1162,19 @@
>  				status = "disabled";
>  			};
>  
> +			qspi: qspi@30bb0000 {
> +				compatible = "fsl,imx7d-qspi";
> +				reg = <0x30bb0000 0x10000>, <0x60000000
> 0x10000000>;
> +				reg-names = "QuadSPI", "QuadSPI-
> memory";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				interrupts = <GIC_SPI 107
> IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_QSPI_ROOT_CLK>,
> +					<&clks IMX7D_QSPI_ROOT_CLK>;
> +				clock-names = "qspi_en", "qspi";
> +				status = "disabled";
> +			};
> +
>  			sdma: sdma@30bd0000 {
>  				compatible = "fsl,imx7d-sdma",
> "fsl,imx35-sdma";
>  				reg = <0x30bd0000 0x10000>;