Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Jul 2020 09:21:45 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Roy Im <roy.im.opensource@diasemi.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Brian Masney <masneyb@onstation.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        Pascal PAILLET-LME <p.paillet@st.com>,
        Rob Herring <robh@kernel.org>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Support Opensource <support.opensource@diasemi.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH v18 3/3] Input: new da7280 haptic driver
Message-ID: <20200729072145.ifzoe656sjpxdior@pengutronix.de>
References: <cover.1595991580.git.Roy.Im@diasemi.com>
 <23b3470401ec5cf525add8e1227cb67586b9f294.1595991580.git.Roy.Im@diasemi.com>
 <20200729063638.GY1665100@dtor-ws>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jb6kq5unqof2j4e3"
Content-Disposition: inline
In-Reply-To: <20200729063638.GY1665100@dtor-ws>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--jb6kq5unqof2j4e3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote:
> > v9:=20
> > 	- Removed the header file and put the definitions into the c file.
> > 	- Updated the pwm code and error logs with %pE
>=20
> I believe the %pE is to format an escaped buffer, you probably want to
> %pe (lowercase) to print errors. I am also not quite sure if we want to
> use it in cases when we have non-pointer error, or we should stick with
> %d as most of the kernel does.

compared with %d %pe is easier to understand as it emits "-ETIMEOUT"
instead of "-110". And yes, %pE is wrong.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jb6kq5unqof2j4e3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl8hI4YACgkQwfwUeK3K
7AkB5gf+N9Wv/PsK4tYxuCcM2KSR0mxt7QizYVPKeAI51kqD6cNZSJbMOdO27yWI
7zr8A//A5v91uqmLbfZHTTK+fEqOFUbM4Btr9/euXT2Hat8S1ADSYsfvEv+6ntdl
HFqjsbx1b13YPATOPoE0vWrTfnKMq9WDpCuc9G68B3fMSTZ9q3WU6bphpEW4viDq
ZxYFYPJLZbVufvzH6Ad3PXwmJpsvtAoLVNzh/ZfFn3luTYKV9tkXb0xneS07xLTx
/4eCgSi7kFlhvc3FGv3usecj3NfZ39EYVLgmwshl2jXa77wQo8NicQarzCfohhz2
g3RvEx1zi/dTCvJYjKH4o1w3GiuF7w==
=McvG
-----END PGP SIGNATURE-----

--jb6kq5unqof2j4e3--