Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [v2,2/3] dt-bindings: watchdog: add a new head file for toprgu
 reset-controllers
To:     Crystal Guo <crystal.guo@mediatek.com>
Cc:     "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        =?UTF-8?B?U2VpeWEgV2FuZyAo546L6L+65ZCbKQ==?= 
        <seiya.wang@mediatek.com>,
        =?UTF-8?B?RXJpbiBMbyAo576F6ZuF6b2hKQ==?= <erin.lo@mediatek.com>
References: <1596004249-28655-1-git-send-email-crystal.guo@mediatek.com>
 <1596004249-28655-3-git-send-email-crystal.guo@mediatek.com>
 <fb7ef8a7-5bbc-8e4b-7a23-c84f151587ba@gmail.com>
 <1596010313.11360.2.camel@mhfsdcap03>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <72d317ef-7f69-9e61-b1d5-23d660c58560@gmail.com>
Date:   Wed, 29 Jul 2020 10:15:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <1596010313.11360.2.camel@mhfsdcap03>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 29/07/2020 10:11, Crystal Guo wrote:
> On Wed, 2020-07-29 at 15:42 +0800, Matthias Brugger wrote:
>> Hi Crystal,
>>
>> On 29/07/2020 08:30, Crystal Guo wrote:
>>> merge all the reset numbers in one head file.
>>>
>>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
>>> ---
>>>    include/dt-bindings/reset-controller/mtk-resets.h | 13 +++++++++++++
>>>    1 file changed, 13 insertions(+)
>>>    create mode 100644 include/dt-bindings/reset-controller/mtk-resets.h
>>>
>>> diff --git a/include/dt-bindings/reset-controller/mtk-resets.h b/include/dt-bindings/reset-controller/mtk-resets.h
>>> new file mode 100644
>>> index 0000000..d73a4ba
>>> --- /dev/null
>>> +++ b/include/dt-bindings/reset-controller/mtk-resets.h
>>> @@ -0,0 +1,13 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> +/*
>>> + * Copyright (C) 2020 Mediatek Inc.
>>> + *
>>> + */
>>> +
>>> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MTK
>>> +#define _DT_BINDINGS_RESET_CONTROLLER_MTK
>>> +
>>> +#define MT2712_TOPRGU_SW_RST_NUM	11
>>> +#define MT8183_TOPRGU_SW_RST_NUM        19
>>
>> Maybe I didn't explain myself properly. We want to have all resets in one file
>> and do not want to have the resets for the watchdog in a different file. That
>> means I don't thin your patch is correct and the effort should be abandoned.
>>
>> Regards,
>> Matthias
> 
> Do you mean to keep the current way unchanged? For example, with a new
> SOC 8192, should add a new head file mt8192_resets.h for the resets
> numbers.
> 

Exactly.

Regards,
Matthias