Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp937220ybg; Wed, 29 Jul 2020 01:22:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2C9ddTBhpbWeZNni6IP/22yp+kjfw49uTIXTFcNCInm7pVzZana6+rL3aqDvFAP37eRY+ X-Received: by 2002:a17:906:82c1:: with SMTP id a1mr18024089ejy.172.1596010942271; Wed, 29 Jul 2020 01:22:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596010942; cv=none; d=google.com; s=arc-20160816; b=nhVFvDXOp2kpewdTYRl+m/XIIUlZJH8ahHaw4zc6xWyc4hHTsS0K+cT+llejRtkDJL A8lRNjkhmDVsa1GucT3OLZBgeJcRxONI+dM/HCcygBv+MTkfcAaTPI92JOX5CcreCpJs pcsi8qTA9MN17JFNKR6Tj3vTeWfvkNZf5B/cUVHnNHI3bMNOO9PZUWcHGh/D20qnsLiN q+QqAYSul4wJ7BHQT4f5iJJF/IOkGhBx8I9OyBwTuo1afvIrfInSorlp41DWVNOtVXU1 r+J+t0nYuG/YCPQaxr6XpEqx+mcgmQqct9BvGrRyzkuXzWJXGfLT1kvGlcrLGhKR2iSP 3Q3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=u4S7zLGGUbGKOYDUdjldjyZhPFPZDXN2pSi+N4AbiBA=; b=kkWhjMfqeUjDlGjWsLXBg6Fyy0vcp873uqKPscYrAqdRXoVOuwYA4dbo0tsI/90obh 9Qp89BjC3pow+kEouAIcskBG0kxQWWXWgiV2QiAheXRJaPQ4baUBUXIeZrdGsJiJyHdU hOlScRojep3pCJIUHEuzeurogx3VT1JDImojq7l81K9tR8jdmq/Le+crYZWKxKsfxbOk 0/YyI5fzz8ADBX0fTXABvYhmLDbspT4v9YlI5QFfxbEfe6QJ3/jYvWljBtpSoi9S+som 9TcsEYYXStEmaERVUhKPs7fwA+D7+HViL/UoyNK2D7TFXlOJyr+cNMVND0Qe0OniyM/f 20qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si872799edm.463.2020.07.29.01.22.00; Wed, 29 Jul 2020 01:22:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbgG2IVb (ORCPT + 99 others); Wed, 29 Jul 2020 04:21:31 -0400 Received: from mga04.intel.com ([192.55.52.120]:31526 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbgG2IVa (ORCPT ); Wed, 29 Jul 2020 04:21:30 -0400 IronPort-SDR: MwdzB/w34CiaCF0gUuOTzkE3r3oWG/Ij5u7OYg51DJMMJlWjlybyKNUc0K0NZpNJBjHdMqDoDN T5Yxd2X1DJJg== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="148835781" X-IronPort-AV: E=Sophos;i="5.75,409,1589266800"; d="scan'208";a="148835781" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 01:21:30 -0700 IronPort-SDR: SEs+jTBkn098s/oKBdX68fNp6mTLX/8uCRzJpdQz0Y7FNdhnKeqweExv/oxzutMRN1J5zyV5et cPP8Fxu0FUOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,409,1589266800"; d="scan'208";a="272562893" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007.fm.intel.com with ESMTP; 29 Jul 2020 01:21:28 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k0hL6-004eQA-1Z; Wed, 29 Jul 2020 11:21:28 +0300 Date: Wed, 29 Jul 2020 11:21:28 +0300 From: Andy Shevchenko To: Maxim Kochetkov Cc: bigunclemax@gmail.com, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: ti-ads1015: fix conversion when CONFIG_PM is not set Message-ID: <20200729082128.GJ3703480@smile.fi.intel.com> References: <20200729075908.10463-1-fido_max@inbox.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729075908.10463-1-fido_max@inbox.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 10:59:07AM +0300, Maxim Kochetkov wrote: > To stop conversion ads1015_set_power_state function use unimplemented > function pm_runtime_put_autosuspend if CONFIG_PM is not set. > If CONFIG_PM is disabled, there is no need to start/stop conversion. > Fix it by adding return 0 function variant if CONFIG_PM is not set. I'm wondering if you check the real code (assembly) for any difference. All calls AFAICS are statically defined in !CONFIG_PM case and compiler/linker should be clever enough to drop this completely. Isn't it the case? -- With Best Regards, Andy Shevchenko