Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /+XJbQt/T6tcFpCeWg+5/d4dHC8NcwjkdX1TUeObzaWLJN4bH+zftm8OnzUed8fCBpEyeD0oKG
 2q/Y0TrQCKbw==
IronPort-SDR: cFBSlrGGkxa6jxqb+55m7agHATOc8LcEqIQlJNuSctxMrRbTYWYzc9VeSPrVATEVjPbTnrUsxK
 psHxcvAvnoxg==
Date:   Wed, 29 Jul 2020 11:34:19 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Maxim Kochetkov <fido_max@inbox.ru>
Cc:     bigunclemax@gmail.com, Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1015: fix conversion when CONFIG_PM is
 not set
Message-ID: <20200729083419.GM3703480@smile.fi.intel.com>
References: <20200729075908.10463-1-fido_max@inbox.ru>
 <20200729082128.GJ3703480@smile.fi.intel.com>
 <5bfad7df-ee64-f94a-003b-06320b9fad0f@inbox.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5bfad7df-ee64-f94a-003b-06320b9fad0f@inbox.ru>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 29, 2020 at 11:26:51AM +0300, Maxim Kochetkov wrote:
> In case of CONFIG_PM is not set:
> 
> static inline int __pm_runtime_suspend(struct device *dev, int rpmflags)
> {
> 	return -ENOSYS;
> }
> 
> and ads1015_read_raw failed at:
> 
> 		ret = ads1015_set_power_state(data, false);
> 		if (ret < 0)
> 			goto release_direct;
> 

I see. Please, elaborate all this in the commit message for v2.

P.S. Avoid top postings!

> 29.07.2020 11:21, Andy Shevchenko wrote:
> > On Wed, Jul 29, 2020 at 10:59:07AM +0300, Maxim Kochetkov wrote:
> > > To stop conversion ads1015_set_power_state function use unimplemented
> > > function pm_runtime_put_autosuspend if CONFIG_PM is not set.
> > > If CONFIG_PM is disabled, there is no need to start/stop conversion.
> > > Fix it by adding return 0 function variant if CONFIG_PM is not set.
> > 
> > I'm wondering if you check the real code (assembly) for any difference.
> > 
> > All calls AFAICS are statically defined in !CONFIG_PM case and compiler/linker
> > should be clever enough to drop this completely. Isn't it the case?
> > 

-- 
With Best Regards,
Andy Shevchenko