Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp967180ybg; Wed, 29 Jul 2020 02:19:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyf72dPovRR4JKgX62Lq+JyKy85PbRv30gmKM1OWSuAQLhylC5lghFPFP3sVco0bzqAP59S X-Received: by 2002:a05:6402:150e:: with SMTP id f14mr17771191edw.39.1596014392502; Wed, 29 Jul 2020 02:19:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596014392; cv=none; d=google.com; s=arc-20160816; b=mV8gKbgfqtQ/DJXdtk2UX9rJPM90fBc1U4Ee3VavUiVlLZZ2yBOb1cnZ7VgFm31Ypo TfvdbiOPwSDpnb6vpypnfWBDzq/EFZZgO1CXBuJnaDVJcFmktLNQvInOMycaWx/TafwM T++EFEovRQc/apkrQ8NMGYVK+mT6slYlh+SDgltEDnw8qaicCVam36ZfNf2OLwBcX49f d5eG61yu7gpd9eGBzRvcB6YsqARflX4cAKkjrdw1pBaQ4PD8BhwBAid9QcwCYiKnkF+g XYcVgDUJHy7Mftf63t6RIkLz1Y0xyaCXQdC6nX8u3KsoJrk0iK4vGAe03NoyG+b+0B1Z 1lIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to:reply-to; bh=5QxkY45+uCy195vrLbQYBt0kHQqjeOPMda3MxmvESpo=; b=dqq7QwqvX1eLXDTgsX/u8yjrEnHmSeBpTbPC3jHdbVWyumiOobxNQy3IwihOmqzQPm nPUKKV5ELVJRc2LH01GFbSFnQgnfwlqcsXoKQjAYReUqcjp5lZIQXzdKkgvLZCJjPxfz zMDAI+GQVMPEUgG7xawvj7XBZN5BXa82w8T8ujINvloPeO7yBgB8m1BUc7Lz55OF1TOB pMqyKxkvJ21i3dEYr7FuoYt5uXNoksLzp3AODW8E3o4ipgUDXcXsPzSfM5AIN1aBNu0b oXTm2XwZ8wsiNDLIJJPzTd63+Yd0LhJM7d8igrAdq9oJTC9+BSMun9F4tcJwtxN/1r6S Vk7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si873023eds.471.2020.07.29.02.19.30; Wed, 29 Jul 2020 02:19:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbgG2JSs (ORCPT + 99 others); Wed, 29 Jul 2020 05:18:48 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38265 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728122AbgG2JSs (ORCPT ); Wed, 29 Jul 2020 05:18:48 -0400 Received: by mail-lf1-f65.google.com with SMTP id 140so12618415lfi.5; Wed, 29 Jul 2020 02:18:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5QxkY45+uCy195vrLbQYBt0kHQqjeOPMda3MxmvESpo=; b=U4bsrf5w/dXVIqf1U43Tlu+fGy6n4kXjZo56Qz57a2rSgFglQPNbtnQ9HoECyEoRxQ 2xidSDi1ySWiAUJMWOvAfjG78amwBzNBgw6icX0OkZASY89TkOYWl2XITUvAsU9wTXcd hZaua3l8Ad/oj9+4z/YV6dxHUsGiNiMY8xCHSXU25wDhdLAzarXtmg+2S275iHHVzfVn OpMSll1OsWuXq1AZmLh+1bPmJ/5F/rr4oculEqnaSlJilkk34NKzVWivozzmbTCjKd+i Z4mTHa2ps0v7HDwELGKxQmYsWomBzUo+IDFMPfgNwzcWMzuyaG6i6p0dGv/KnWOCifuQ 9LIw== X-Gm-Message-State: AOAM533obqtluuCH2iWCBZskOjqfbymKRgX2m/YSI4Mjwhw0P1LMaeQt nnU8VMDxFTHa2NchcqmMOck= X-Received: by 2002:a05:6512:752:: with SMTP id c18mr16550623lfs.53.1596014324266; Wed, 29 Jul 2020 02:18:44 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id d14sm325942lfj.30.2020.07.29.02.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2020 02:18:43 -0700 (PDT) Reply-To: efremov@linux.com To: Peilin Ye , Jens Axboe Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Dan Carpenter References: <20200728141946.426245-1-yepeilin.cs@gmail.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Subject: Re: [Linux-kernel-mentees] [PATCH] block/floppy: Prevent kernel-infoleak in raw_cmd_copyout() Message-ID: Date: Wed, 29 Jul 2020 12:18:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728141946.426245-1-yepeilin.cs@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/20 5:19 PM, Peilin Ye wrote: > raw_cmd_copyout() is potentially copying uninitialized kernel stack memory > since it is initializing `cmd` by assignment, which may cause the compiler > to leave uninitialized holes in this structure. Fix it by using memcpy() > instead. > > Cc: stable@vger.kernel.org > Fixes: 2145e15e0557 ("floppy: don't write kernel-only members to FDRAWCMD ioctl output") Nitpick, I would say this fix is not related to commit 2145e15e0557. > Suggested-by: Dan Carpenter > Suggested-by: Arnd Bergmann > Signed-off-by: Peilin Ye