Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1040229ybg; Wed, 29 Jul 2020 04:22:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxI3xs3jP7ckTjD+jHoYGfwY56HrqTeZ9h8o4jVvZmno7G/2Q4QFcE2oozDSz91lvQrJ3yp X-Received: by 2002:a05:6402:1427:: with SMTP id c7mr15058062edx.245.1596021746102; Wed, 29 Jul 2020 04:22:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596021746; cv=none; d=google.com; s=arc-20160816; b=lg2+J3AbQS71xA1yqrpFL01hTr2QwPOTkTEvL7rHxZ9Q7WSECAHUI2qcSg7zvmwjew yveh4b9mTwCX05m8Us+ht2LzainxJMqNuoeAwJAfbmCBx2FZ5kd7+TZUjZe0IxTOmals ax47v54vQX36SAbo56OQyxFr/h9h0Hv+FXAnqLrpuBHhvLp2TxGwnkKqRG0gwEC4bJ/e 6qiMLLkAcCKQ89O+FMx2LlYeOgkg8n89BhWXoSPAEsUNe3uTD/6NJmWCdiR06792gmqX iMAIzkpgyoVsrPqgAtsW8sULOQAmK0ALbj8wvP55jrxeuIpjPe2KbaWDJaSb4uPNfSbV XOWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=q4tp4m1jnxwuvRbmbxSPWN4NELjKqxYKRbv2apgwiWo=; b=YAgBb4NysHs1/b++PXFCOClECm79G4W6sI6I7wfBZUPA3zrKPB4mYGVXfZVuLHoYYW /FrusjNMlHNkei8I83lQFyDrHXGsyFn3m5s3kCC3Ld/Wf/37H0Vr0kN3g+Mcdgzi54QX hY6+VM70wd6kTqAQRrdTcc26xev8CK8IRDQ346Q8NYYqaA+Og2lSsSHSYoZUymr/yneL 3ehJ/HIKiAu2cJSlqSEKZRQqsOPlwe4FzUCTJPJ3VQxzgBxkRqgeLPJz0aNVaukFrqZE UCtvEfs12KrrQilb9jVqBPFuKuWPy7+EwkY3U0bDs0TP1qWN1Y41KvLCfRVkxO2X8kZq 129g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si1048850edj.121.2020.07.29.04.22.03; Wed, 29 Jul 2020 04:22:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgG2LVF (ORCPT + 99 others); Wed, 29 Jul 2020 07:21:05 -0400 Received: from mga18.intel.com ([134.134.136.126]:55036 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgG2LVF (ORCPT ); Wed, 29 Jul 2020 07:21:05 -0400 IronPort-SDR: 18iHv6XdLqFXD35fSjkb7J4wShsS9ScKZH8jDb82a01za2ChQBUshzX1sEutqD1v3Y23HeEzFo 6jcRR70ZrONQ== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="138926296" X-IronPort-AV: E=Sophos;i="5.75,410,1589266800"; d="scan'208";a="138926296" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 04:21:01 -0700 IronPort-SDR: uqPcMaoUSfpo404KJkP5rqAgdej4Bq4CoZPFgIA0ojK34SC5ckBeziVeNCr3s0uvbDpJskNQdK aZiFwh7DhfeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,410,1589266800"; d="scan'208";a="364818643" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 29 Jul 2020 04:20:57 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k0k8f-004gBc-KZ; Wed, 29 Jul 2020 14:20:49 +0300 Date: Wed, 29 Jul 2020 14:20:49 +0300 From: Andy Shevchenko To: Brent Lu Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Ranjani Sridharan , linux-kernel@vger.kernel.org, Daniel Stuart , Yu-Hsuan Hsu , Guennadi Liakhovetski , Kai Vehmanen , Sam McNally , Damian van Soelen Subject: Re: [PATCH 0/2] Add period size constraint for Atom Chromebook Message-ID: <20200729112049.GW3703480@smile.fi.intel.com> References: <1596020585-11517-1-git-send-email-brent.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596020585-11517-1-git-send-email-brent.lu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 07:03:03PM +0800, Brent Lu wrote: > Two different constraints are implemented: one is in platform's CPU > DAI to enforce period sizes which are already used in Android BSP. The > other is in Atom Chromebook's machine driver to use 240 as period size. One nit to one patch. Overall, LGTM and thus FWIW, Reviewed-by: Andy Shevchenko > Brent Lu (1): > ASoC: intel: atom: Add period size constraint > > Yu-Hsuan Hsu (1): > ASoC: Intel: Add period size constraint on strago board > > sound/soc/intel/atom/sst-mfld-platform-pcm.c | 15 +++++++++++++++ > sound/soc/intel/boards/cht_bsw_max98090_ti.c | 14 +++++++++++++- > sound/soc/intel/boards/cht_bsw_rt5645.c | 14 +++++++++++++- > 3 files changed, 41 insertions(+), 2 deletions(-) > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko