Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [greybus-dev] [PATCH][next] greybus: Use fallthrough
 pseudo-keyword
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Alex Elder <elder@kernel.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
        Johan Hovold <johan@kernel.org>
References: <20200727183258.GA28571@embeddedor>
 <63871608-e076-26b0-85df-cff11699c3a3@ieee.org>
 <20200729105157.6acksxuzjdno5omq@vireshk-mac-ubuntu>
From:   Alex Elder <elder@linaro.org>
Message-ID: <e45f807e-dc35-b335-fca0-424d56e05f09@linaro.org>
Date:   Wed, 29 Jul 2020 07:15:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200729105157.6acksxuzjdno5omq@vireshk-mac-ubuntu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/29/20 5:51 AM, Viresh Kumar wrote:
> On 28-07-20, 17:37, Alex Elder wrote:
>> On 7/27/20 1:32 PM, Gustavo A. R. Silva wrote:
>>> Replace the existing /* fall through */ comments and its variants with
>>> the new pseudo-keyword macro fallthrough[1].
>>>
>>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>>
>> Thanks for the patch.  It looks good, but it raises
>> another question I'd like discussion on.
>>
>> It seems that Johan likes default (or final) cases in
>> switch statements without a "break" statement.  Viresh
>> and Bryan appear to be fond of this too.
>>
>> It's pedantic, but I don't like that.  Am I wrong?
>>   --> Johan/Viresh/Bryan would you please comment?
> 
> I am not fond of them as they aren't required for the working of the code. It is
> a bit like using an empty return statement for a routine with void return type,
> though it surely adds some consistency to the switch case.

I understand this perspective, and it's exactly why I wanted
to have a conversation about it (rather than just saying it
should be fixed).  As similar example, I don't like unnecessary
parentheses, but sometimes it's a good idea to have them.

Thanks.

					-Alex

> But if people really feel it must be there, then its fine :)
>