Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1217461ybg; Wed, 29 Jul 2020 08:34:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+8UTjX/QEwZrHcWDvmlhM5DWA+IaWYyO/zmoHGj1wjBsrlvxbGpb/e3QffnIyR0dB/rpp X-Received: by 2002:a17:906:3c43:: with SMTP id i3mr20412699ejg.133.1596036874385; Wed, 29 Jul 2020 08:34:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596036874; cv=none; d=google.com; s=arc-20160816; b=Dm1LO6eCpmMQdMUdsq0BKtOxCv5WSIADOw2yJ3YEuLVJnFoxJJz5rl8p+vKujKFJMo EW77GAKCcZqgDBwI+5+z8TAa/EkB4R/u1gr07R2oUv4/oVrqlXTxHo+jv0Fi0v5EPO6r fPBPbYDDWPk/SFi9+5b2OOv6N4br0+I1+Bk8pvIkirPqSUEdVSEwTCHOy8k1bamrWDSm JxEoFuQxRlGHP5fHkrCVCG/6zFtNYxEIED1wg9d22TEiZ5ptipvM38SMUSAx9xlxDRRj CwIyrG7oL3SpPGw4Wb5Fi/fiNuEEaeidAGa53Uq+c/WOm7IGZPMgw9yu/6Q+ZzJb0/ZG Gjkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LptujKmB75cZgkeinHbWmkaPdhq6d/VPDGBKjyx/cG0=; b=sqxadjZ8TQzcV68jvfSu1HDY5xO2KaX7XtPPx9DKS+pZfDRdQs1AUgeijhLxBXphwp fWitkqr1hx5UkdLJe4nbf4wGQi0LbJAFiNRqJnkKSwolv4z3QOjPQOANGThD7cBVpGko r6EyOUCcp/Xll8+VQGipXD1O8Vd8PRbySJYJH5TbG9Z2Xx6xd1/MxM56UxI0ked0T5qS /BZ7NY5+2L0CBFUypGfL4wyzJ7z/uGZzm4rXE+KVZQ+DSC3Jv3UnvqF2WD1iX982HKF2 G3z4iNKGZ0gHtiFx+StlWfF5E7SbcshFqi74O1VA14KXgozobwGSLF7Oo2fO+ol+Eb6V D/EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=QQT6atMv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck3si564811edb.324.2020.07.29.08.34.11; Wed, 29 Jul 2020 08:34:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=QQT6atMv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgG2Pdz (ORCPT + 99 others); Wed, 29 Jul 2020 11:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbgG2Pdz (ORCPT ); Wed, 29 Jul 2020 11:33:55 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16202C061794; Wed, 29 Jul 2020 08:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LptujKmB75cZgkeinHbWmkaPdhq6d/VPDGBKjyx/cG0=; b=QQT6atMvYBKttOHS5earNdJ65+ ShnVfAiY4r06zZHni02DP1u45D0v/1crgTXoXCCXUPXsbHhWlood6tYOdxP9GWb7v9WB1HaePzAd0 BuWbyc4AJ3uQpemLrIhsVIkfDc0eOkN+yqX1EQwD0peX9MlfCwF9uBGYsJ9TRbJ4d1Ij1SQlINuDz FY4urNjx6Imqc8iSzU8gD/HmQd1bY5kIpVAGCOKPx55JUKG8WrAW+a9sJr9G2PuyqZ7R+92CBag2v PC4NkCsZ/UHXUHKMJOEeHYgo/umFEmN1vTkuhysdbn+yey5Dhe+yKpNxiFxzRocuHxsWG1eADZYN8 zkEffa3A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0o5P-00061e-3T; Wed, 29 Jul 2020 15:33:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6AAD2300238; Wed, 29 Jul 2020 17:33:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 26D8D203D2862; Wed, 29 Jul 2020 17:33:41 +0200 (CEST) Date: Wed, 29 Jul 2020 17:33:41 +0200 From: peterz@infradead.org To: Matthew Wilcox Cc: mingo@kernel.org, will@kernel.org, a.darwish@linutronix.de, tglx@linutronix.de, paulmck@kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, corbet@lwn.net, davem@davemloft.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition Message-ID: <20200729153341.GE2638@hirez.programming.kicks-ass.net> References: <20200729135249.567415950@infradead.org> <20200729140142.347671778@infradead.org> <20200729145507.GW23808@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729145507.GW23808@casper.infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > Manual repetition is boring and error prone. > > Yes, but generated functions are hard to grep for, and I'm pretty sure > that kernel-doc doesn't know how to expand macros into comments that it > can then extract documentation from. > > I've been thinking about how to cure this (mostly in the context > of page-flags.h). I don't particularly like the C preprocessor, but > m4 is worse and defining our own preprocessing language seems like a > terrible idea. > > So I was thinking about moving the current contents of page-flags.h > to include/src/page-flags.h, making linux/page-flags.h depend on > src/page-flags.h and run '$(CPP) -C' to generate it. I've been a little > busy recently and haven't had time to do more than muse about this, but > I think it might make sense for some of our more heavily macro-templated > header files. Use ctags and add to scripts/tags.sh.