From: Denis Vlasenko <vda@ilport.com.ua>
To: Michael Buesch <mb@bu3sch.de>
Subject: Re: [patch 9/9] Add bcm43xx HW RNG support
Date: Fri, 12 May 2006 18:16:54 +0300
User-Agent: KMail/1.8.2
Cc: akpm@osdl.org, Deepak Saxena <dsaxena@plexity.net>,
       bcm43xx-dev@lists.berlios.de, linux-kernel@vger.kernel.org,
       Sergey Vlasov <vsu@altlinux.ru>
References: <20060512103522.898597000@bu3sch.de> <20060512103649.060196000@bu3sch.de>
In-Reply-To: <20060512103649.060196000@bu3sch.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="koi8-r"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605121816.55025.vda@ilport.com.ua>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 30

On Friday 12 May 2006 13:35, Michael Buesch wrote:
> +static int bcm43xx_rng_read(struct hwrng *rng, u32 *data)
> +{
> +	struct bcm43xx_private *bcm = (struct bcm43xx_private *)rng->priv;
> +	unsigned long flags;
> +
> +	bcm43xx_lock(bcm, flags);
> +	*data = bcm43xx_read16(bcm, BCM43xx_MMIO_RNG);

You are storing random 16-bit value _and_ 16 zero bits
into 32-bit memory location. Probably not a problem for
little-endian machine (you return 2, indicating that there
are only 2 bytes of randomness), but on big endian?

Didn't you mean

	*(u16*)data = bcm43xx_read16(bcm, BCM43xx_MMIO_RNG); ?

> +	bcm43xx_unlock(bcm, flags);
> +
> +	return (sizeof(u16));
> +}

--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/