Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1283640ybg; Wed, 29 Jul 2020 10:07:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1/xl0ud0FIrN6fFxrpXD1eBO9tnp55P7O8SDJL01lN68O6inxIGKdnOVC2kf6QWIDK0z9 X-Received: by 2002:aa7:d155:: with SMTP id r21mr29499983edo.87.1596042453758; Wed, 29 Jul 2020 10:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596042453; cv=none; d=google.com; s=arc-20160816; b=dQzB7z7hx6XhZPF33dw+rEhKE5P8fmIVZO55LXoNKY2NO3QkTxr9XlTN7Yb2mitKjz 9wLyVYcYoENRIAJ+Cbx/JLRSwMTrzJbwy8re+2qR0Ptaw4h6Kkfk/6a7j2X+7zTOGLPP f35ZsK0vaWWy/EfLFXgg62SS5edmjBaHkpEwL4KOnXIdt82KhD8NUcgKbMDf7V3tJt6w RgQ8OrjiFOX5wErHIrMWcs3RHnBlrIESynvwxVAib2jG2MK0VxyH+YBrniwspZ573H0S z6EFJCiEmxhrg3+GZgE1SJpenjVvMlI/W/2u9ZIt/4tZ2pxKHyg9bMuHFYWIziN23yg8 VUjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/R9LPDtVvFK4l31XPH1TROOfY4r68RjAJPXbTSUHqVY=; b=Xz7Z6SBTsIMZQZ8bVOcBXlUEJwQKKAu7yaLwfqK3/ZLbCd818DJ1TS26Ttj7QMLiYd Q4ISi+kbVMxCZxKLcXKt8n3N2Vy7AZ3j0aV/AnuDdXdKp+H6/VdLfVT+uBFaBUfhH8+2 jQ9qlidbAxu2LPrEGoz3lpacT2+LuTZn8OTXdzH7fKLfbOFc55u8JaZXZGVKJB4b/SVw kTPLR1TyBLOP3c6AfUFi+HUkd0UPHTr08Vg5chsMJidfZj3nAXnl/4iKQMZ2j1PmNsm6 5Z88hTRZkCfZcv3fa3CMKHpyIPp9MHlDOaaB79Yk0BE5A+adrc95J32tMACbKodHq0YR YPog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f13si1369586ejq.631.2020.07.29.10.07.10; Wed, 29 Jul 2020 10:07:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbgG2RGW (ORCPT + 99 others); Wed, 29 Jul 2020 13:06:22 -0400 Received: from verein.lst.de ([213.95.11.211]:52987 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbgG2RGW (ORCPT ); Wed, 29 Jul 2020 13:06:22 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C594968AFE; Wed, 29 Jul 2020 19:06:19 +0200 (CEST) Date: Wed, 29 Jul 2020 19:06:19 +0200 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Jessica Yu , Christoph Hellwig , open list , live-patching@vger.kernel.org Subject: Re: [PATCH 2/7] modules: mark find_symbol static Message-ID: <20200729170619.GA2279@lst.de> References: <20200729062711.13016-1-hch@lst.de> <20200729062711.13016-3-hch@lst.de> <20200729161318.GA30898@linux-8ccs> <20200729162435.GB3664300@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729162435.GB3664300@kroah.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 06:24:35PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 29, 2020 at 06:13:18PM +0200, Jessica Yu wrote: > > +++ Christoph Hellwig [29/07/20 08:27 +0200]: > > > find_symbol is only used in module.c. > > > > > > Signed-off-by: Christoph Hellwig > > > > CCing the livepatching ML, as this may or may not impact its users. > > > > AFAIK, the out-of-tree kpatch module had used find_symbol() in the > > past, I am not sure what its current status is. I suspect all of its > > functionality has been migrated to upstream livepatch already. > > We still have symbol_get(), which is what I thought they were using. And even if it didn't out of tree modules really don't matter.