Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1343092ybg; Wed, 29 Jul 2020 11:36:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYRzcKsi7+rypsZ/ciz8u2BzYaGBxv6NG8fYymFVb1S4VosLLhd/AavdPFBGkjjGdyElA3 X-Received: by 2002:a50:ec93:: with SMTP id e19mr31327856edr.254.1596047798211; Wed, 29 Jul 2020 11:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596047798; cv=none; d=google.com; s=arc-20160816; b=np/wk/Ntp04WlC7JoUEVUC16VtuBlGcoYdmdg872ZQYK94CYBsq7M7aKepJSr1Gfr4 bspDcBBKjcvdQ70qRShox4X9p3Mu50DdWg4CjDjf8L7GY58SN6c41ZOKItJnsom9XVWs epo7pS811WPI3M1/S4EIp0LSFuCk7OpegcyBySG2f0mu+3KnXNCkFb5UF2US5694Ybup ttltEjzqw4rbk/NPfoJRiwkaYTzhvoVc1kM3Hs1TikZYS/aclDKw5MG6DSASCVsml+Vv nVZlNKEFYv096vmHOkuLW6bh/2uuKdAnHhjHGX2iPjkmoFnEXhZ5TVwcfMvy7+C1iBgF EBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=3QuIhOvbPPB9XM2WftKT9SKANlKh1T59MgfKSRu5wDs=; b=vx8EoZWXqwf0jFwZQfjS04cHRFEB55pjMPeuBlwgRONKV3J1CiO1uvpnCanzpgBZQw Wk2ulr4xpujVVjkcK6eT2NFki+qgpkRmqb1AVM/vryE3iBrsNr08EtQeGi5yoYI3MER0 1cpQoNqXVV2GysC8BCqUR3gBljapRn/LJ6lXWJYuTyB1WUJHLXNUJ8OpG5jAqhqEMc4C bOP3sTRkZCI49t1OGTy4zs8WstfKfZo6j/2UEby/unspweJqyzYQRjxm72P0kXm8KWid bFPgGuls1bBCtFEJ8uhpv5y0/J4UmPcECbpv3UmmMUDohnbE2qXBc0qIo8kFny8FGpZG x8yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=c+hg1ZrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si1819929edp.43.2020.07.29.11.36.15; Wed, 29 Jul 2020 11:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=c+hg1ZrT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgG2SgH (ORCPT + 99 others); Wed, 29 Jul 2020 14:36:07 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60242 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgG2SgG (ORCPT ); Wed, 29 Jul 2020 14:36:06 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06TIVxgx018213; Wed, 29 Jul 2020 18:35:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=3QuIhOvbPPB9XM2WftKT9SKANlKh1T59MgfKSRu5wDs=; b=c+hg1ZrTNQEljpNXsefaZLQ3NSmBIm4/jrENLLB9Jj03Y8hX7cT/NOF1lT0Zjm6H+c5S UOWme/FNNWWqkCHBlBspQR21nQG7MeV78lSlCz/4n33ja2DuSaEwHVY+V+HnwfEif23R AR/m5IrDEVL7izW2R4Hhmtmo04u1IDOJqQ5gXdHkL2Ps8ZvEjLuB8cZIdN6mSvra0Nfp 4PtVWrhFYjeC+kzwuWlFvym8IlIgKEO/vv86TUcLOv0DGRn/t2f1gWopDs2UEYzWHIXU 1YddQP+lt9tgOXq67RZjX2n+99p5687f7xkla2WcUHL2QSQ36IusO7f2DW9fD8c52QS4 Ug== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 32hu1jfbkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Jul 2020 18:35:54 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06TIWV69194155; Wed, 29 Jul 2020 18:35:53 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 32hu5xp7ad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jul 2020 18:35:53 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06TIZqRf017180; Wed, 29 Jul 2020 18:35:52 GMT Received: from [192.168.2.112] (/50.38.35.18) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Jul 2020 11:35:52 -0700 Subject: Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate() To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Andrew Morton , Michal Hocko , "Michael S.Tsirkin" References: <20200630142639.22770-1-david@redhat.com> <20200630142639.22770-3-david@redhat.com> <6a05470a-75be-e895-dff6-ed494af8d6d9@oracle.com> <7d32cdd3-7f19-2916-1930-33236bf33e19@redhat.com> From: Mike Kravetz Message-ID: <79240e7f-de16-aee6-fbf6-07e7f184a924@oracle.com> Date: Wed, 29 Jul 2020 11:35:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7d32cdd3-7f19-2916-1930-33236bf33e19@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9697 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007290125 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9697 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 clxscore=1015 mlxscore=0 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007290125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/20 11:08 AM, David Hildenbrand wrote: > I have no clue what you mean with "reintroducing this abandoning of > pageblocks". All this patch is changing is not doing the dump_page() - > or am I missing something important? My apologies!!! I got confused when I saw 'Return -EBUSY' removed from the comment and assumed the code would not return an error code. The code now more explicitly does return -EBUSY. My concern was when I incorrectly thought you were removing the error return code. Sorry for the noise. Acked-by: Mike Kravetz -- Mike Kravetz