Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Jul 2020 13:28:42 -0700 (PDT)
Message-Id: <20200729.132842.190888844026802233.davem@davemloft.net>
To:     saeedm@mellanox.com
Cc:     songliubraving@fb.com, hawk@kernel.org, kafai@fb.com,
        kpsingh@chromium.org, john.fastabend@gmail.com, leon@kernel.org,
        linux-kernel@vger.kernel.org, ast@kernel.org,
        linux-rdma@vger.kernel.org, xiongx18@fudan.edu.cn, yhs@fb.com,
        andriin@fb.com, kuba@kernel.org, daniel@iogearbox.net,
        bpf@vger.kernel.org, netdev@vger.kernel.org,
        xiyuyang19@fudan.edu.cn, tanxin.ctf@gmail.com,
        yuanxzhang@fudan.edu.cn
Subject: Re: [PATCH] net/mlx5e: fix bpf_prog refcnt leaks in mlx5e_alloc_rq
From:   David Miller <davem@davemloft.net>
In-Reply-To: <613fe5f56cb60982937c826ed915ada2de5e93a2.camel@mellanox.com>
References: <20200729123334.GA6766@xin-virtual-machine>
        <613fe5f56cb60982937c826ed915ada2de5e93a2.camel@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Saeed Mahameed <saeedm@mellanox.com>
Date: Wed, 29 Jul 2020 19:02:15 +0000

> On Wed, 2020-07-29 at 20:33 +0800, Xin Xiong wrote:
>> The function invokes bpf_prog_inc(), which increases the refcount of
>> a
>> bpf_prog object "rq->xdp_prog" if the object isn't NULL.
>> 
>> The refcount leak issues take place in two error handling paths. When
>> mlx5_wq_ll_create() or mlx5_wq_cyc_create() fails, the function
>> simply
>> returns the error code and forgets to drop the refcount increased
>> earlier, causing a refcount leak of "rq->xdp_prog".
>> 
>> Fix this issue by jumping to the error handling path
>> err_rq_wq_destroy
>> when either function fails.
>> 
> 
> Fixes: 422d4c401edd ("net/mlx5e: RX, Split WQ objects for different RQ
> types")

Saeed, are you going to take this into your tree or would you like me to
apply it directly?

Thanks.