Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Jul 2020 18:38:36 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
CC:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Kernel Team <kernel-team@fb.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 29/35] bpf: libbpf: cleanup RLIMIT_MEMLOCK
 usage
Message-ID: <20200730013836.GA637520@carbon.dhcp.thefacebook.com>
References: <20200727184506.2279656-1-guro@fb.com>
 <20200727184506.2279656-30-guro@fb.com>
 <CAEf4BzZjbK4W1fmW07tMOJsRGCYNeBd6eqyFE_fSXAK6+0uHhw@mail.gmail.com>
 <20200727231538.GA352883@carbon.DHCP.thefacebook.com>
 <CAEf4BzamC4RQrQuAgH1DK-qcW3cKFuBEbYRhVz-8UMU+mbTcvA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEf4BzamC4RQrQuAgH1DK-qcW3cKFuBEbYRhVz-8UMU+mbTcvA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:9282) by BYAPR05CA0037.namprd05.prod.outlook.com (2603:10b6:a03:74::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.9 via Frontend Transport; Thu, 30 Jul 2020 01:38:39 +0000
X-Originating-IP: [2620:10d:c090:400::5:9282]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0248e60-2ab7-4eb1-dfc3-08d8342948fd
X-MS-TrafficTypeDiagnostic: BYAPR15MB3398:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB339819828465A9657AEF71FBBE710@BYAPR15MB3398.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: D4eJA4UZhnNuEFqD20+B84hdY40u2My+w0YLZssl7ca2IqgXxV4p9Nhsq7MvAVDI0x3XSjmesT8MmkrN8JZjYYgpH0x0s8WvwMHBKRvtBPEmoCsVdSbKLjqn613U7rEfIh0IZra68EMK3NxgB0z3AE/kxXCHQun94ARRLF3EeHOAqJp/8ogttejGKMt2816RP5z8zMZulJv7/HCEcpcnx4omUa0h9h63fd6hWzNM35SHqOdtb/sI0W6RBgg+VnQzlHYrOZnseoHgby78GsMoZlcyNuRqLw4mwFI2Goi/CvfuXzGLosvLcVyKjNYtR/IyvhR5Ldb/dZstyzU8gspRrw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(39860400002)(136003)(366004)(376002)(53546011)(6506007)(33656002)(1076003)(86362001)(8676002)(83380400001)(7696005)(4326008)(52116002)(5660300002)(54906003)(66476007)(66556008)(6916009)(2906002)(55016002)(66946007)(316002)(6666004)(186003)(16526019)(478600001)(8936002)(9686003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: 59+VrRaN6YiE8FOnX1BRwFOMAhQ1H5LPuc+V3neLUoal4kxvp1Vb9Eeo5aCxG2M2reNDKI3TxDCMPqiR3I4p0PBl+KyVPn8Eqv6adgJ76y3CkUSVdn5xJCtknMUsrlPh7AyTbCUZcOlfXT7q3HwsZcu8m5TnonypICJ1jo5BjqBo9U21gd+5M0NDmyR8if0rq0u4uLBFf6QtHUGh297gQ9sbpIXqcZSlVHLSa06O3vQykCrFoxUa2WchExuVtJ+BUcAkemMh6CcXkIPTWxwK1I/+XtvfT+luuD5wBujYREaZigFf55KgmirPtBUo69jsv3qHr/959oM4lwiCsnpZzNsWq2hsFuwOoh51YHwxVyOh3JNh+EwKOquTyKA4BPUzY5A1vpzfEZoZSkPdeZ9rYyERfIMO1TuHSkhgB6nPRSNRWGAn978xQM0Pey3+IACvcwZvHURJK24BvpXOnGuiTsqtElsQ78YuTOfGje5PP6iYBucj3hLaM0olDUm4ZaRZXoMToqBhvguRZPstk4MAMQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: f0248e60-2ab7-4eb1-dfc3-08d8342948fd
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2020 01:38:40.0833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qISZIKmAjFvHaE997ktQDMS26nMVhzBJLLJVs+ALLRnhQtMmm1OdITFwJhkLLl3Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3398
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-07-30_01:2020-07-29,2020-07-30 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 spamscore=0
 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0
 mlxscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0
 mlxlogscore=999 suspectscore=1 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2006250000 definitions=main-2007300009
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 27, 2020 at 10:59:33PM -0700, Andrii Nakryiko wrote:
> On Mon, Jul 27, 2020 at 4:15 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > On Mon, Jul 27, 2020 at 03:05:11PM -0700, Andrii Nakryiko wrote:
> > > On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin <guro@fb.com> wrote:
> > > >
> > > > As bpf is not using memlock rlimit for memory accounting anymore,
> > > > let's remove the related code from libbpf.
> > > >
> > > > Bpf operations can't fail because of exceeding the limit anymore.
> > > >
> > >
> > > They can't in the newest kernel, but libbpf will keep working and
> > > supporting old kernels for a very long time now. So please don't
> > > remove any of this.
> >
> > Yeah, good point, agree.
> > So we just can drop this patch from the series, no other changes
> > are needed.
> >
> > >
> > > But it would be nice to add a detection of whether kernel needs a
> > > RLIMIT_MEMLOCK bump or not. Is there some simple and reliable way to
> > > detect this from user-space?

Btw, do you mean we should add a new function to the libbpf API?
Or just extend pr_perm_msg() to skip guessing on new kernels?

The problem with the latter one is that it's called on a failed attempt
to create a map, so unlikely we'll be able to create a new one just to test
for the "memlock" value. But it also raises a question what should we do
if the creation of this temporarily map fails? Assume the old kernel and
bump the limit?
Idk, maybe it's better to just leave the userspace code as it is for some time.

Thanks!