Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1589869ybg; Wed, 29 Jul 2020 19:23:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyAWCMFhTPYgAyq7DJVaR/BCYmDpnGgNSNOoZ/xzpZInmNAW8TcS8Vw3kmxXgjLyJUdO+3 X-Received: by 2002:a17:906:aed0:: with SMTP id me16mr498133ejb.288.1596075837595; Wed, 29 Jul 2020 19:23:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596075837; cv=none; d=google.com; s=arc-20160816; b=gZbyDyPC9IYtVxg0eZBpkGAimCPHVypLbUSpiMb8TWLtGt9cbRyJU4329ePhNvZBZX cYv1zARk+jnuOVr8OmcBKq5MEEOXBNu+IXWzHE91IlofIpJee0/ahV+BzY66yn7uEtrS 5KeBdjYWmSH+Ql0X0o9kh+INVocQ3wpqjg5rijShv6VHNQCUTgoPOBqNWNVqsJkgypCj mffWUO7deW4vLcV/d2CdqZMbh9ZuSmmx4Uw1wlQ+0fNo/CgUR7s1S1izj0AtJwU2WD30 fpGqBt52bCcGLZvQm7gKM/6S0NTR++k3OcA+RKAz/vrq+nz3OQt+fE5q/r2sCGE4NM/T UFJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=85IVjEgWwmnF0/67S9nE7//289tb3cmtxK/vE6du/ds=; b=G4825OKOPDOGrbOFfq+SsUHJuoRwtMuixe3uJDFBSw6Rngy4QnqbGkwkTELS4No2rO u+SkuzjOY0AfWyAKGzleFvupsi9yfMqZ3hqtoIu5ZDCFMNHUiCZdaw6vs+QM7oi/mYys w0zablaqbp8v+7Yi66XzgbLXtLGqcXU7FwSDJH1SH6COnbIxUTAd6XgtkBSkrr7s/D30 Pc4GA7J0U5Rl9lc3FNd5Q+AGnpTRDvSsv3i2JDLo8345Zdg+agJqsj1jCoXPA+0A4/EP B5CT5z0apmsI7e8yc7y1IAiImlk2mrQI1/eiRMHSugHRyGoiARVfjAkYSkt9cdtplcmA ETbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr21si3451097ejc.713.2020.07.29.19.23.21; Wed, 29 Jul 2020 19:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728385AbgG3CXD (ORCPT + 99 others); Wed, 29 Jul 2020 22:23:03 -0400 Received: from namei.org ([65.99.196.166]:56338 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726342AbgG3CXC (ORCPT ); Wed, 29 Jul 2020 22:23:02 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 06U2MmBY004068; Thu, 30 Jul 2020 02:22:48 GMT Date: Thu, 30 Jul 2020 12:22:48 +1000 (AEST) From: James Morris To: Kees Cook cc: Greg Kroah-Hartman , Scott Branden , Christoph Hellwig , Mimi Zohar , Luis Chamberlain , Takashi Iwai , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 04/17] fs/kernel_read_file: Split into separate include file In-Reply-To: <20200729175845.1745471-5-keescook@chromium.org> Message-ID: References: <20200729175845.1745471-1-keescook@chromium.org> <20200729175845.1745471-5-keescook@chromium.org> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2020, Kees Cook wrote: > From: Scott Branden > > Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h > include file. That header gets pulled in just about everywhere > and doesn't really need functions not related to the general fs interface. > > Suggested-by: Christoph Hellwig > Signed-off-by: Scott Branden > Reviewed-by: Christoph Hellwig > Acked-by: Greg Kroah-Hartman > Link: https://lore.kernel.org/r/20200706232309.12010-2-scott.branden@broadcom.com > Reviewed-by: Mimi Zohar > Reviewed-by: Luis Chamberlain > Signed-off-by: Kees Cook Acked-by: James Morris -- James Morris