Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1591578ybg; Wed, 29 Jul 2020 19:28:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzojZouF4uV47CKwpcrvu3SuQuFZirDYSQMl2m2EBJj6V+SV84TvuBtLHigG74ITAbjkT6q X-Received: by 2002:a05:6402:1545:: with SMTP id p5mr628954edx.388.1596076098294; Wed, 29 Jul 2020 19:28:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596076098; cv=none; d=google.com; s=arc-20160816; b=WvY4sAQhKGuvgrd8gUpjHuQacGIx7acjB6yn+WVgQzQBlu50q498fsjxNZO+kSWfa4 EeSzbUQkTu2YxL5LnTw6uiIp35wpBULG5qJRu/19BNSbGaQy6MdtPE5ySdFMVUAN0bGm 3+Tgj8J8TlESUXdCOUiD0Hf1WYibfkT35uO7bwyZvbaaHsLYYmqVATTpGTJe377xXX3K PlAJuMFILrpkioIMIOJSHa5VzuRv178rQeD4wQbSGuM1cta+6rACDymSA+aivCCudO/M p8iAKQKQBHuBuGqxlaldh3doySkxqSQJq8f0wOGo8WivI4nmDh7HX0NqNi2P2A1h9sec ZnSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=2wHaCu2zojY3vN2V1xzIjZ8qEgnnX3UUOjNaprIb82A=; b=SI0TbgVvznMWL+R/ZpmD0bPShOi7YaUCGzlxh5jSfcdZlYEdOopHXdYGbMN5ooJLAg P+ukkMUVkaa9/PoMM9aXXVdkhuKBP0pnhvXd/opCcKo5sFfDu/zobt9X+ncz5dkInIgt AladMEUftpKUIomZViy9vJ17+hUVR7kqyVrHWOxdsXywpasYplFqu/Hu6VUobgIdfQy9 4DgY4CJHdzzSvi3ZUWWZDROCQybN9z1Z1Z0uFWqNJgqvLFRsz/N0XrlCgj3YhcCRB2Cj Sy7Ppju+MXv9SSxaqD9ubYazN/gkvCvZUu4rx75PP0Xo9HliOamUSNRidNjeeCYCAcqA XY4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ot7si2153784ejb.747.2020.07.29.19.27.56; Wed, 29 Jul 2020 19:28:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728439AbgG3CZN (ORCPT + 99 others); Wed, 29 Jul 2020 22:25:13 -0400 Received: from namei.org ([65.99.196.166]:56428 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbgG3CZM (ORCPT ); Wed, 29 Jul 2020 22:25:12 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 06U2P5cj004220; Thu, 30 Jul 2020 02:25:05 GMT Date: Thu, 30 Jul 2020 12:25:05 +1000 (AEST) From: James Morris To: Kees Cook cc: Greg Kroah-Hartman , Scott Branden , Mimi Zohar , Luis Chamberlain , Takashi Iwai , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/17] fs/kernel_read_file: Remove redundant size argument In-Reply-To: <20200729175845.1745471-7-keescook@chromium.org> Message-ID: References: <20200729175845.1745471-1-keescook@chromium.org> <20200729175845.1745471-7-keescook@chromium.org> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2020, Kees Cook wrote: > In preparation for refactoring kernel_read_file*(), remove the redundant > "size" argument which is not needed: it can be included in the return > code, with callers adjusted. (VFS reads already cannot be larger than > INT_MAX.) > > Acked-by: Scott Branden > Reviewed-by: Mimi Zohar > Reviewed-by: Luis Chamberlain > Signed-off-by: Kees Cook Reviewed-by: James Morris -- James Morris