Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1593978ybg; Wed, 29 Jul 2020 19:33:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEi9+KAuj1nUP/ScWHMQzDnFTzCkOjRxXy/EhYav66ftFA2D/x905kd5MqN/YLW8uJlfjZ X-Received: by 2002:a17:906:3281:: with SMTP id 1mr531724ejw.132.1596076405261; Wed, 29 Jul 2020 19:33:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596076405; cv=none; d=google.com; s=arc-20160816; b=HXfj8GsIImS7JsY6Ctt/0zQGeR9q9JIwnfg4C/2CjnqG5y3bd8WD0purTBOVrZWm3b nU/pBQQxOPkxOLek6UbBa/cyy95SUxw+WVDUTROnMtrysuKQU30R6LyWXS40WL+8ykZG iyglLU8THF2T0PUhPxM7gKr4wBYyPpptv8f+oYcaEea0YZxvwBEPmcHMSRQgpe/qzw1N Cc/XDqoXxZGe8wdakw4PXqoRTxu9sIcVo0W1qdk0XAHjfjnLu2Iug71S+uhKs2AYvNvb WFPg5cb5SPMs91GC+qh/1KAw7+gxAWmfpcnumh3TTE2Kd08f8ICRyNzQ97GpDnx12fjE rSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=i37yX2uFveO0+iOJgTKM+YOc3T575VUZpXe9jH9CLdI=; b=bW8YkwEFZ2axzFIe2pdnP8dda7RuGus3dQSIvg179+k6gOo4yjdMJUellhBtFEFRQR BWRe+lQ8cRP+IGyb8uOt3sn+XBAPjwbqGgCQmIA0pPK7YCAbUETS3LlJAWOyluWxlITe 2ttN5cbOCmrPMuyQAT2WBH40JD5ry7GiOTg0DKyiBfeFE1wU1glFNTjyv68GLUL53CPV px0NcRvxm+e7DdXBz9CEaBRaNo2U7M2PsfnJGnQrBCuMZEt9LNcaIc0Hy54BrTVe115k S5ENZ8oKC4S3GYrIexjekiVt3eQ+PehQM7fmgqahwoNtjHibRDK6VkV8dRIVhijOlyHu xd+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u16si2408877eje.469.2020.07.29.19.33.03; Wed, 29 Jul 2020 19:33:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbgG3CbB (ORCPT + 99 others); Wed, 29 Jul 2020 22:31:01 -0400 Received: from namei.org ([65.99.196.166]:56468 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbgG3CbA (ORCPT ); Wed, 29 Jul 2020 22:31:00 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id 06U2QGu7004321; Thu, 30 Jul 2020 02:26:16 GMT Date: Thu, 30 Jul 2020 12:26:16 +1000 (AEST) From: James Morris To: Kees Cook cc: Greg Kroah-Hartman , Scott Branden , Mimi Zohar , Luis Chamberlain , Takashi Iwai , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/17] fs/kernel_read_file: Add file_size output argument In-Reply-To: <20200729175845.1745471-9-keescook@chromium.org> Message-ID: References: <20200729175845.1745471-1-keescook@chromium.org> <20200729175845.1745471-9-keescook@chromium.org> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2020, Kees Cook wrote: > In preparation for adding partial read support, add an optional output > argument to kernel_read_file*() that reports the file size so callers > can reason more easily about their reading progress. > > Acked-by: Scott Branden > Reviewed-by: Mimi Zohar > Reviewed-by: Luis Chamberlain > Signed-off-by: Kees Cook Reviewed-by: James Morris -- James Morris