Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1688338ybg; Wed, 29 Jul 2020 23:16:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwurRW9+pxpqXy0C8MuqmhSi8fJ1QQLXPf35VkNTdFocSfj549JPaM1SGfe5J/dgpgAr8wG X-Received: by 2002:a17:907:4303:: with SMTP id nh3mr1161196ejb.520.1596089816634; Wed, 29 Jul 2020 23:16:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596089816; cv=none; d=google.com; s=arc-20160816; b=jKj8c3W1N6QK0UvQYDXdRt3K0iNvBOCcgDGZk8w41mSkdH+gQmdeKR1vhJfTOx8gjr ueqQtbeTiLL1q0eRXkqUPpnl/+uN+IYfS8q8fD5e7T+Ii37RCD+7e/khclxrrM3kp0NM pXxjj1rypcrqfO+0KQVS/abdf0pxnVB85nPmPX9oKCuEpN0c7ZqIy+FuUR3JYp299uRx MqQzsXS0EZ2J3ghmKK9FjSvQuv+QC7zf2//aPYPUqpAagwyvV92jrFcgylZh78QO0XlS E9IFVIgaUSHsAmSC5CICdAWyvwe7a4f2tZGuLq9cF/KCWy7rnJFCE4ecMi2r8t98lhpq M3CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=wPCb2VFdjvDhXRP3DfgfjpN8ZaNuvN7uvt/adgetpzc=; b=OSNpaMP0Pyjxj3sZA4rbnk7jlrSzKzjVkYO11jstXu8YMruuXNRxD20PPTyTbaNYRF 2mEYhDEps/eVNvXriHQtSnwfstbHjQgLE7CoUQWIjy+cl4uQi2FTVrBtUPZlfo64eICt Uwj019gz1t/zcmvhbWDdUgKj+y20erU7kQyo4zpngVdRg7WaYxjsXDS9WBA5gq2xCC1F Tzn2eobrDAMdbDgt9Y0IgaAGZpzgcwvrreYXIqWLeKrfTvLpNO0zJzWezPriHf++UmaI AApAU0tmGWGxRmwE6r/xS+pk7oV6y7inr58ZpHHznM8wkEZDEtwM5A/GHSC4UF44Vv2A T1lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rn4si2572796ejb.569.2020.07.29.23.16.35; Wed, 29 Jul 2020 23:16:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728724AbgG3GOC (ORCPT + 99 others); Thu, 30 Jul 2020 02:14:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8859 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725892AbgG3GOC (ORCPT ); Thu, 30 Jul 2020 02:14:02 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AFAD96AE6D963B38DD14; Thu, 30 Jul 2020 14:14:00 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 30 Jul 2020 14:13:51 +0800 From: Kai Ye To: , , , CC: Kai Ye Subject: [PATCH] uacce: fix some coding styles Date: Thu, 30 Jul 2020 14:13:03 +0800 Message-ID: <1596089583-32687-1-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1. delete some redundant code. 2. modify the module author information. Signed-off-by: Kai Ye --- Changes in V2: deleted extra NULL pointer check in uacce_fops. drivers/misc/uacce/uacce.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c index 107028e..1d09707 100644 --- a/drivers/misc/uacce/uacce.c +++ b/drivers/misc/uacce/uacce.c @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma) switch (type) { case UACCE_QFRT_MMIO: - if (!uacce->ops->mmap) { - ret = -EINVAL; - goto out_with_lock; - } - - ret = uacce->ops->mmap(q, vma, qfr); - if (ret) - goto out_with_lock; - - break; - case UACCE_QFRT_DUS: if (!uacce->ops->mmap) { ret = -EINVAL; @@ -541,5 +530,5 @@ subsys_initcall(uacce_init); module_exit(uacce_exit); MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Hisilicon Tech. Co., Ltd."); +MODULE_AUTHOR("HiSilicon Tech. Co., Ltd."); MODULE_DESCRIPTION("Accelerator interface for Userland applications"); -- 2.8.1