Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
CC:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: virtio: support sharing vdev buffer
Thread-Topic: [PATCH] remoteproc: virtio: support sharing vdev buffer
Thread-Index: AQHWYCa/ZQ2evnRBnkWEXL5ROMcq8qke1I4AgACcW6A=
Date:   Thu, 30 Jul 2020 06:21:59 +0000
Message-ID: <DB6PR0402MB2760BF33BCBFF1CD1F1C4EED88710@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20200722131543.7024-1-peng.fan@nxp.com>
 <20200729170516.GA3059951@xps15>
In-Reply-To: <20200729170516.GA3059951@xps15>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d08d2b62-3405-481f-63a0-08d83450de11
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2020 06:21:59.9355
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: czkgfQx9OWE44LGDbxNvlowxgP11NNEVYjK3BvttiEjchgyZsE6PHZnJO1yZFIk27twSnEZygJVjDzYT18HJYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5081
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mathieu,

> Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer
>=20
> Hi Peng,
>=20
> On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote:
> > Support sharing vdev buffer between multiple vdevs by using name
> > "vdevbuffer".
> >
> > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/remoteproc/remoteproc_virtio.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/remoteproc/remoteproc_virtio.c
> > b/drivers/remoteproc/remoteproc_virtio.c
> > index dfd3808c34fd..5d78ebea111e 100644
> > --- a/drivers/remoteproc/remoteproc_virtio.c
> > +++ b/drivers/remoteproc/remoteproc_virtio.c
> > @@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev,
> > int id)
> >
> >  	/* Try to find dedicated vdev buffer carveout */
> >  	mem =3D rproc_find_carveout_by_name(rproc, "vdev%dbuffer",
> > rvdev->index);
> > +	if (!mem)
> > +		mem =3D rproc_find_carveout_by_name(rproc, "vdevbuffer");
>=20
> We already have a way to share buffers [1], do you think it would work fo=
r you?
> I would rather proceed that way to avoid introducing a 3rd way to deal wi=
th
> vdev buffers.

That should work for me. I just need to move the vdevbuffer to the 1st one
inside the memory-region.

BTW: Do you have time to give a review for
https://patchwork.kernel.org/patch/11688751/

Thanks,
Peng.

>=20
> Thanks,
> Mathieu
>=20
> [1].
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Felixi=
r.b
> ootlin.com%2Flinux%2Fv5.8-rc4%2Fsource%2Fdrivers%2Fremoteproc%2Frem
> oteproc_virtio.c%23L389&amp;data=3D02%7C01%7Cpeng.fan%40nxp.com%7C
> 760ae238005c49fe20db08d833e193ca%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%7C0%7C0%7C637316391223184319&amp;sdata=3DUTN8YVaEynomrwFx
> 7aTCJ7fp0fjfIS8fscfGG67naKk%3D&amp;reserved=3D0
>=20
> >  	if (mem) {
> >  		phys_addr_t pa;
> >
> > --
> > 2.16.4
> >