Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>,
        <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc:     <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
        <Motai.Hirotaka@aj.MitsubishiElectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@samsung.com>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <fa122230-e0fd-6ed6-5473-31b17b56260c@gmail.com>
Subject: RE: [PATCH] exfat: retain 'VolumeFlags' properly
Date:   Thu, 30 Jul 2020 15:59:04 +0900
Message-ID: <015e01d6663e$e99e4ec0$bcdaec40$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQJOchBlupSQwdEhi4rggGDYoy3yLwE5agcKAmVRsN0CrFCHjgKKBjVEAx7tf5ECsQmAL6e6b/8Q
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200708095813epcas1p2277cdf7de6a8bb20c27bcd030eec431f@epcas1p2.samsung.com>
        <20200708095746.4179-1-kohada.t2@gmail.com>
        <005101d658d1$7202e5d0$5608b170$@samsung.com>
        <TY2PR01MB2875C88DD10CC13D0C70DE1690610@TY2PR01MB2875.jpnprd01.prod.outlook.com>
        <015801d65a4a$ebedd380$c3c97a80$@samsung.com>
        <ad0beeab-48ba-ee6d-f4cf-de19ec35a405@gmail.com>
        <fa122230-e0fd-6ed6-5473-31b17b56260c@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Ping..
Hi Tetsuhiro,

> 
> On 2020/07/15 19:06, Tetsuhiro Kohada wrote:
> >> It looks complicated. It would be better to simply set/clear VOLUME DIRTY bit.
> >
> > I think exfat_set_vol_flags() gets a little complicated, because it
> > needs the followings (with bit operation)
> >   a) Set/Clear VOLUME_DIRTY.
> >   b) Set MEDIA_FAILUR.
> 
> How about splitting these into separate functions  as below?
> 
> 
> exfat_set_volume_dirty()
> 	exfat_set_vol_flags(sb, sbi->vol_flag | VOLUME_DIRTY);
> 
> exfat_clear_volume_dirty()
> 	exfat_set_vol_flags(sb, sbi->vol_flag & ~VOLUME_DIRTY);
Looks good.

> 
> exfat_set_media_failure()
> 	exfat_set_vol_flags(sb, sbi->vol_flag | MEDIA_FAILURE);
Where will this function be called? We don't need to create unused functions in advance...

> 
> 
> The implementation is essentially the same for exfat_set_vol_flags(), but I think the intention of the
> operation will be easier to understand.
Yes.

Thanks!
> 
> 
> BR
> ---
> Tetsuhiro Kohada <kohada.t2@gmail.com>