Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1719939ybg; Thu, 30 Jul 2020 00:23:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVgwxEoeGaldAzdGKsH1uAPne3AIty8ywCs7gJ5Fnc4/CdzXsn+Xv3e1S9zpomPQW3RQVA X-Received: by 2002:aa7:d814:: with SMTP id v20mr1337316edq.296.1596093814204; Thu, 30 Jul 2020 00:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596093814; cv=none; d=google.com; s=arc-20160816; b=Xfo/9sk+AeoNz/3ZvHtMdtYrE5BV0SChx8vRQvayj4EdczT2vPwjMkLkDEiyA25R/v JRFudr3KHp29E/lH+CsqQdEoeUCbEEl6hOaxlCPHaHaA9jRiJ118N9T42mdKKQpA6ET1 EIjGufILVvK42Gll1u718mzvaR1Lbq8FnlPITsAbPRr0HtNE3ZUeIDH+ep0wAXTL0yHp t+LjhNIp2rqv7Qh+SlE4KJNXe1AGhmCtzglVyLkpTdCSbV4i37YfJv3FVu4Cz2H7hQkD bVe23n1d8hgXZaL7dwXL7Swhvp2F59LAIyHR2Br2myTz4/2jTPpapHRJagZsy6+ZMCkk rYFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=+NgQtL5ncAbkAE+z0O6UDrsFO/u7aht+qMA9loj1tN4=; b=KyWysm0/whx83sjEnUZyY/Ul/yc2E/u1+xprULTGA3Ko4NfGATirIVoLMmqviV1o+3 OYlkxRi80tcpmjVK3XkENtrjqMLD+2p0I8ZcULdYZAMWAUT9G1DJhUhtQ5UGJVH1YZuN 8NUMMlco9dwCpG5uaGcp38sj57PyB9Es6DuaNVlgk9oZjMCUvisoiQ2jLp44+7u9J1+O 8OWhdcZzNY+YQIvFntB66tmIvhy6YSw4HMAXbQG4FYM8+6NvgBCjpUpya9Ny0GTERNZC LNsddv8CHLvnAKY5Q1AOKcmkl1mDtQcKUJJ+9NMzcLx9T/d9HavXcwDaYRGnjmDmPFf/ X1jQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si2789961edy.106.2020.07.30.00.23.12; Thu, 30 Jul 2020 00:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728726AbgG3HW6 (ORCPT + 99 others); Thu, 30 Jul 2020 03:22:58 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:34301 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgG3HW5 (ORCPT ); Thu, 30 Jul 2020 03:22:57 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MQMi7-1kNERt0L45-00MNCV; Thu, 30 Jul 2020 09:22:56 +0200 Received: by mail-qt1-f174.google.com with SMTP id s23so19615039qtq.12; Thu, 30 Jul 2020 00:22:53 -0700 (PDT) X-Gm-Message-State: AOAM530fhtgVFVvlfB1uelJE+JEgih2QNvxapO06tLFngmOEKUT/zDUC QObTt4DApdgH4AyADhwZPkDqh6f3cvWac6seKuk= X-Received: by 2002:aed:2946:: with SMTP id s64mr1685167qtd.204.1596093772891; Thu, 30 Jul 2020 00:22:52 -0700 (PDT) MIME-Version: 1.0 References: <1596067120-1193-1-git-send-email-Anson.Huang@nxp.com> <1596067120-1193-2-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1596067120-1193-2-git-send-email-Anson.Huang@nxp.com> From: Arnd Bergmann Date: Thu, 30 Jul 2020 09:22:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V8 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits To: Anson Huang Cc: Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Dong Aisheng , Peng Fan , Abel Vesa , Andy Duan , Daniel Baluta , YueHaibing , linux-clk , "linux-kernel@vger.kernel.org" , Linux ARM , NXP Linux Team Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:lTCNq6hS062jBYwG/0GIfHXkumSjMFIvurIOIr1sjAjklefzOjg /S9ZbtnvL1By5DV1PGooPwKuLutxGv1sdLPlSRA5T8qToxRu+RsGKj2glzxTq/2g31Akmkt aVCZAU1r7Gh9aQNgxZIJ8LkWNqTS5NcOPBDMNdUHDVNey4sH4Kel/etwOclYf2oV19R+fRG c6vk4IYKF1va9Gt04IItQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dbWKEXZ+pNs=:v9SopY0XoxPhD/hztbdTmI U+3Ca5dH70Dxkw8EgjIa893dTsdwVW4D4u2N1E2WeAMy1WPwUN8hSywgSg9UHp3DE0Uvv06b5 v2wrPFl5Sv8MEVbVFxl9Y0CvnrhrVO/iELiqae1vq6kpGEfJ7k+GmfYsoLxmABDAdNYyntL8w XO4UUX7AyyDHSgcP0qk95lyeO2JdfVo1FWVqz/LwHoWE8uF6ocRhDb3I8Hl/4T6bFYNkQRIlY vQ5nzLkMN+827t0DI8tccP3/3Lc/OHpG6YWr+gva/WQj3y9Cqu6FwxcUSeMTWAcxiJvE6IrEM INoA/0JexkpxUUBi36Qfy75UJYM1sDbH/qyVr93/0Kf8q7FNfrZ/GR0pl372JQam5CSFuOzsL OUtG8+9GG3ZSU3YsEV3ntnIG/n8Au7RI9CvQm2BJHFaR6GaGBFyCLpQeUBJUKiFEDW94NVx0I uFUNFEpyPEHCZfGxpzMqMgBZGuiXtvjKIg25fPJtfQqLGT86M/VIhxWMpJKo4UgPrhzpwA8xT Nv3hw0MfQgn9149B3OJi9c0E+q5Vrxhm7fQT5lJGtdiQ+brZVsJ4Yn5ZiBKaRuTlCIK5Hvewg irkrurjHCFcIeHN3ItM8I36twIxtc8Uzg/nvdjEBX2UJ3N2zm3rpn2pOYpk9GMqzrcpjPFl+n s84uIEB75SuGRecYZ7JJB1X4pyYh63vlhj9u6hGQdAkVZzs1g7NWkYqJPcrb2ZFkOEfn5zxFU QkwJ32TNYkxhb8gc6IjGLyGsNV34F1OJPqrSUMeINFT8lBFF08cF1vKOIVqXVrwaW1q13N0X5 7ckmdDCUpl4y9PXNDOW5Sj8f43LSfSAbVpr2hlz/l9XvOFTmp1BRVCQ8ITl20SaZFhURKfW Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 2:03 AM Anson Huang wrote: > > Use readl_relaxed() instead of __raw_readl(), and use BIT(x) > instead of (1 << X) to fix below build warning reported by kernel > test robot: > > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit > value by 31 bits is undefined behaviour [shiftTooManyBitsSigned] > while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK)) > > Signed-off-by: Anson Huang > Reported-by: kernel test robot Acked-by: Arnd Bergmann