Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbWELS67 (ORCPT ); Fri, 12 May 2006 14:58:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751323AbWELS66 (ORCPT ); Fri, 12 May 2006 14:58:58 -0400 Received: from stat9.steeleye.com ([209.192.50.41]:24002 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1751322AbWELS66 (ORCPT ); Fri, 12 May 2006 14:58:58 -0400 Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache From: James Bottomley To: Linus Torvalds Cc: Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, rmk@arm.linux.org.uk, axboe@suse.de, Linux Kernel Mailing List In-Reply-To: <1147456038.3769.39.camel@mulgrave.il.steeleye.com> References: <20060511151456.GD3755@harddisk-recovery.com> <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com> <20060512171632.GA29077@harddisk-recovery.com> <1147456038.3769.39.camel@mulgrave.il.steeleye.com> Content-Type: text/plain Date: Fri, 12 May 2006 13:58:45 -0500 Message-Id: <1147460325.3769.46.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 26 On Fri, 2006-05-12 at 12:47 -0500, James Bottomley wrote: > I'll look at the release paths and see if I can work out what it is. OK, here's the scoop. The problem patch adds a get of driverfs_dev in add_disk(), but doesn't put it again until disk_release() (which occurs on final put_disk() of the gendisk). However, in SCSI, the driverfs_dev is the sdev_gendev. That means there's a reference held on sdev_gendev until final disk put. Unfortunately, we use the driver model driver_remove to trigger del_gendisk (which removes the gendisk from visibility and decrements the refcount), so we've introduced an unbreakable deadlock in the reference counting with this. I suggest simply reversing this patch at the moment. If Russell and Jens can tell me what they're trying to do I'll see if there's another way to do it. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/