Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1753913ybg; Thu, 30 Jul 2020 01:33:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJze+Ng7/s7XNzukmZ/gwfiTJpWHDObX38FQWIgT4B3shfx/YwyTzXQUUqhLXNezn7R6R4+q X-Received: by 2002:a17:906:a284:: with SMTP id i4mr1618738ejz.490.1596098034226; Thu, 30 Jul 2020 01:33:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596098034; cv=none; d=google.com; s=arc-20160816; b=BooHJxe4rNCgi6Yk3eEfJEmjhsElIYXPqzSkOndw7XBF5RLEZAP+/xuQHrZCZ6pD07 v/tvH6suGWN9Gd/aKgrUNPfa0PBnex0oQgEw86BQFSVDNTYIFwHH911SaK40iZj30sSZ KSl8ru7lJga4phVQNr5mVGgnew8TLZuc2FvjpfmTRxXVCnzdAkahPH80Nz/XI2AeJc6q HQA2AZ4vwl9feriYtjYbN0TJPUwA+5CvfQxEHMX029We2cAXVTn9fb5/bWmj8SX71lsw WASts0aM7wOMsIY9k6NvtbI+4HC364V+ZzL8IrLZN81rvolCqui3Fh+Rg/4Z4TdGw7FS Kbtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=drm9sLf52miFW+dx2clcaSLRFJaD8D3kXKRL8DxyMXE=; b=wua+iXA/Bi+n4ojO1tBL4S5qPdBM29n+mwJyP6RzPF7/uWeYxKfkV94ym9gnBAXH6j ioBqajvXlSALuHkDZFKrx0ZW4ZtGEg17yzgYnpv5KUl6NzT/xIXqz6zuf97z37EtopPb nC15l0pTYQU9D8vIIh94mvuF+ovBACDDo0DUtfMmLSWA/PcWoWmXEziqH8dilVXRUdXc mjA/C3+VVMkmoGjoFGrGhtEayHq7pihKSqCmGBhn02WJdhw5t4GEhzmQLUNa9h+i8fBA RXVoit9I0um43H7mylcv3DeaFDLaBXZgxyniG4RG2OZq7abjxg1yn/TjKJp5b78F0ZYr n01w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si2007265ejq.668.2020.07.30.01.33.31; Thu, 30 Jul 2020 01:33:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729130AbgG3IbF (ORCPT + 99 others); Thu, 30 Jul 2020 04:31:05 -0400 Received: from mga12.intel.com ([192.55.52.136]:59652 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728850AbgG3IbE (ORCPT ); Thu, 30 Jul 2020 04:31:04 -0400 IronPort-SDR: eDu5NXabJ6tzA7DATUEyiPXWtBOL2jhzIlUKbQafYpCU+PT/EscvChTL75BocMdK20vmibEpOF AAwjbqX3VaZg== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="131118949" X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="131118949" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 01:31:04 -0700 IronPort-SDR: ffGzBVTSxb8GpJc5oh3CKyQ0enNV7diTBxOIIzSwAJmju32x4zKCZ4nucAIkxFyY399Tj+DSj3 EuyzMacinsYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,413,1589266800"; d="scan'208";a="272865479" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007.fm.intel.com with ESMTP; 30 Jul 2020 01:31:00 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k13xq-004sgj-T2; Thu, 30 Jul 2020 11:30:58 +0300 Date: Thu, 30 Jul 2020 11:30:58 +0300 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Dmitry Torokhov , Roy Im , Bartosz Golaszewski , Brian Masney , Greg KH , Lee Jones , Luca Weiss , Maximilian Luz , Pascal PAILLET-LME , Rob Herring , Samuel Ortiz , Thierry Reding , Thomas Gleixner , Support Opensource , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes Subject: Re: [PATCH v18 3/3] Input: new da7280 haptic driver Message-ID: <20200730083058.GC3703480@smile.fi.intel.com> References: <23b3470401ec5cf525add8e1227cb67586b9f294.1595991580.git.Roy.Im@diasemi.com> <20200729063638.GY1665100@dtor-ws> <20200729072145.ifzoe656sjpxdior@pengutronix.de> <20200730050653.GA1665100@dtor-ws> <20200730061631.y4r4s6v3xepktj54@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200730061631.y4r4s6v3xepktj54@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-K?nig wrote: > On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-K?nig wrote: > > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: ... > > Maybe we should introduce something like '%de' for the integer error > > case? > > I suggested that some time ago with limited success, see > https://lore.kernel.org/lkml/20200129115516.zsvxu56e6h7gheiw@pathway.suse.cz/ Oh, please, no need for that really. We have now dev_err_probe() on its way to upstream (now in Greg's tree) which hides all this behind. Just switch to dev_err_probe() and forget about what is under the hood. -- With Best Regards, Andy Shevchenko