Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [v2,1/3] dt-binding: mediatek: mt8192: update mtk-wdt document
To:     Crystal Guo <crystal.guo@mediatek.com>
Cc:     "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        =?UTF-8?B?U2VpeWEgV2FuZyAo546L6L+65ZCbKQ==?= 
        <seiya.wang@mediatek.com>,
        =?UTF-8?B?RXJpbiBMbyAo576F6ZuF6b2hKQ==?= <erin.lo@mediatek.com>
References: <1596016922-13184-1-git-send-email-crystal.guo@mediatek.com>
 <1596016922-13184-2-git-send-email-crystal.guo@mediatek.com>
 <c6ea8852-0381-0924-185e-083ea167f8fa@gmail.com>
 <1596072913.11360.12.camel@mhfsdcap03>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <47a351dd-7b67-6280-a80f-c5299a4f260a@gmail.com>
Date:   Thu, 30 Jul 2020 11:02:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1596072913.11360.12.camel@mhfsdcap03>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 30/07/2020 03:35, Crystal Guo wrote:
> On Wed, 2020-07-29 at 18:18 +0800, Matthias Brugger wrote:
>>
>> On 29/07/2020 12:02, Crystal Guo wrote:
>>> update mtk-wdt document for MT8192 platform
>>
>>
>> should be two patches. one fixing the compatibles and second adding new board.
>>
>>>
>>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
>>> ---
>>>    Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> index 4dd36bd..e36ba60 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>>> @@ -4,14 +4,15 @@ Required properties:
>>>    
>>>    - compatible should contain:
>>>    	"mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
>>> -	"mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
>>> +	"mediatek,mt2712-wdt": for MT2712
>>>    	"mediatek,mt6589-wdt": for MT6589
>>>    	"mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
>>>    	"mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
>>>    	"mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
>>>    	"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
>>> -	"mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
>>> +	"mediatek,mt8183-wdt": for MT8183
>>
>> We will need to update the DTSI in a seperate patch as well.
> 
> Yes, this patch is based on
> https://patchwork.kernel.org/patch/11690401/ , which modify description
> for mt2712 and mt8183.
> 

I don't understand your comment. This patch modifies the binding. The link you 
provide is from an older version of the series (which is called v2 as well...)

So repeating myself: if you are updating the binding descritpion you will have 
to update the dtsi as well as otherwise the binding and the dtsi are out of sync.

Regards,
Matthias