Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1797342ybg; Thu, 30 Jul 2020 02:58:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJLcQyN8u0jKVDHwGlWh3Ol0MhSlLi81CHAeMgULImJK5f0hXZKYZWydg7hh3XbSnfJhQf X-Received: by 2002:a05:6402:16c2:: with SMTP id r2mr1803855edx.127.1596103131083; Thu, 30 Jul 2020 02:58:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596103131; cv=none; d=google.com; s=arc-20160816; b=OHw3QyahCu10I5K17k9Yd0GxL90zur6jejyJjFJwHI1XIYLZhukmcxvsuJof8B0gGt jAJsvgfkF5KOUgaf4tEDWUYRml7ipOO/Pn/EaYNyZgVi/wpWhBgTz+li+4tJgU6Zk+YS Qmw+tOkY75CC2IkSqF9gP/lO4htxNc03J9uD8MDKZbAht62T6Y7JlnWEXqYb3yjQFW7X 1/BciQW7y90Racl8/nTq6dNhtAPIWRG2lzF4b6Pi58o/Ei9jJft43b8oZyPc41BZ1v3b UYiu/mHCsJwMyzEZQT1iz0JO+1dQ0YsugkKqXQ5paK4PNdeOwga7i/VFoLbFV1yHGEHA fWyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3r0Hn9iO5Act6f5eDm4E4OUK9iFb6mqTx6+phUYPKkk=; b=ndsFdXlQf4drK3uyCK/gXqKBILDhROyqPYgYks52bN9gL8QU6Ld8rOoKpYOeo+AxEv MosXMHkXbIvV8s7XyaYvy9FU/K4leMoxfDoiGbAsNI9FH45g0s3HgxaCgXi+npEjI/me K8Z7bIY65VV6RQKE8ucf39XHzcjTpeAXMQYfoKkpX/cAWtUXQSnAYdiLmthAyXpfI67A Q/ATybQdC+9myDZ84LZSBFIF5o5savcP7ZpPrUwGPR0ct+pz01VQPEAMHh6vaA0dnj2j Wy9pUh2lSinBR7dCSvEaRhZM2c7KblqAYSp8L4RtriQ0fsIzK7+lAiQ6qBivzG3FHnAr hBAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=tQYKkvR6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly14si1837444ejb.369.2020.07.30.02.58.29; Thu, 30 Jul 2020 02:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=tQYKkvR6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726929AbgG3J6K (ORCPT + 99 others); Thu, 30 Jul 2020 05:58:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbgG3J6J (ORCPT ); Thu, 30 Jul 2020 05:58:09 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D843C061794 for ; Thu, 30 Jul 2020 02:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3r0Hn9iO5Act6f5eDm4E4OUK9iFb6mqTx6+phUYPKkk=; b=tQYKkvR6ZwUL3Xuxsj5Kds/awW D3bUco/lkYC7+zRTdvP07C4IFJx6uTDS8+7g3n/3XCrleViG/ZmNh3Vr0bztdYNvrZVvr2HwQC1DC hkjezQTrfSXQyJDElw+rRnoKft0ySGnZTNhbLOAosmuZDMinnRIiNTocEGBKCrgarGo9+xuqOcVmQ orVTXcARAA+/lsyNPLSzMikwu8c0CHRUECUIia5tHEy+VZcwNExe+QflEp6JWc/iZNSf85YpuRQ4z wWhHhEKMD4spNuwFf606mXkX5D9TtPDGV4H8tcfRmbm465BNuTsRWVrnam9YD4Nvu7wlgcEouICwU qgDsYA9A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k15K7-00024j-9B; Thu, 30 Jul 2020 09:58:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B58A330066E; Thu, 30 Jul 2020 11:57:59 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A140E210ECD11; Thu, 30 Jul 2020 11:57:59 +0200 (CEST) Date: Thu, 30 Jul 2020 11:57:59 +0200 From: peterz@infradead.org To: Julien Thierry Cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, mhelsley@vmware.com, mbenes@suse.cz Subject: Re: [PATCH v3 2/4] objtool: Move orc outside of check Message-ID: <20200730095759.GH2655@hirez.programming.kicks-ass.net> References: <20200730094143.27494-1-jthierry@redhat.com> <20200730094143.27494-3-jthierry@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200730094143.27494-3-jthierry@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2020 at 10:41:41AM +0100, Julien Thierry wrote: > + if (file->elf->changed) > + return elf_write(file->elf); > + else > + return 0; > } I think we can do without that else :-)