Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750797AbWELU6R (ORCPT ); Fri, 12 May 2006 16:58:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750815AbWELU6R (ORCPT ); Fri, 12 May 2006 16:58:17 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:19210 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750797AbWELU6Q (ORCPT ); Fri, 12 May 2006 16:58:16 -0400 Date: Fri, 12 May 2006 21:58:04 +0100 From: Russell King To: Linus Torvalds Cc: James Bottomley , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Andrew Vasquez , Linux Kernel Mailing List , Greg KH Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Message-ID: <20060512205804.GD17120@flint.arm.linux.org.uk> Mail-Followup-To: Linus Torvalds , James Bottomley , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Andrew Vasquez , Linux Kernel Mailing List , Greg KH References: <20060511151456.GD3755@harddisk-recovery.com> <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com> <20060512171632.GA29077@harddisk-recovery.com> <1147456038.3769.39.camel@mulgrave.il.steeleye.com> <1147460325.3769.46.camel@mulgrave.il.steeleye.com> <20060512203850.GC17120@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 43 On Fri, May 12, 2006 at 01:50:46PM -0700, Linus Torvalds wrote: > On Fri, 12 May 2006, Russell King wrote: > > Great, I'm fucked by the SCSI folk again. > > No, you introduced a regression. This isn't the SCSI layer being evil, > this is the "regressions aren't acceptable". No - I introduced a correct fix. I think actually we're heading towards needing Linux V2 - the rewrite. It seems that fixing simple bugs cause other bugs, and that means we're heading into a maintainability nightmare. > > Can we revert the patch which broke the MMC/SD layer - the one which > > added the mount/unmount hotplug events as well then. > > > > That way we get back to a working MMC/SD layer as well as a working > > SCSI layer. > > That's certainly the logical fix - push the pain up the chain to the > person who introduced it. Which commit is that, do you know? No idea I'm afraid, and since I've had a _really_ extremely shitty couple of days I'm not about to start going to look for it. > Really, the added ref-count should be gotten by whoever holds on to the > thing, and it sounds like it's the hotplug event that caused this and > should have held on to its hotplug reference. ... which would be the genhd layer - it's keeping the driverfs_dev around so that the genhd layer can generate hotplug events using it at mount/umount time. Thanks for just re-confirming my original fix and that it's SCSI which is the real problem. 8) -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/