Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750837AbWELVDN (ORCPT ); Fri, 12 May 2006 17:03:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751106AbWELVDN (ORCPT ); Fri, 12 May 2006 17:03:13 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:12047 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750837AbWELVDM (ORCPT ); Fri, 12 May 2006 17:03:12 -0400 Date: Fri, 12 May 2006 22:03:01 +0100 From: Russell King To: Greg KH Cc: Linus Torvalds , James Bottomley , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Andrew Vasquez , Linux Kernel Mailing List Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Message-ID: <20060512210300.GE17120@flint.arm.linux.org.uk> Mail-Followup-To: Greg KH , Linus Torvalds , James Bottomley , Erik Mouw , Or Gerlitz , linux-scsi@vger.kernel.org, axboe@suse.de, Andrew Vasquez , Linux Kernel Mailing List References: <20060511151456.GD3755@harddisk-recovery.com> <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com> <20060512171632.GA29077@harddisk-recovery.com> <1147456038.3769.39.camel@mulgrave.il.steeleye.com> <1147460325.3769.46.camel@mulgrave.il.steeleye.com> <20060512203850.GC17120@flint.arm.linux.org.uk> <20060512205215.GA26501@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060512205215.GA26501@kroah.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 34 On Fri, May 12, 2006 at 01:52:15PM -0700, Greg KH wrote: > On Fri, May 12, 2006 at 09:38:50PM +0100, Russell King wrote: > > On Fri, May 12, 2006 at 12:09:50PM -0700, Linus Torvalds wrote: > > > On Fri, 12 May 2006, James Bottomley wrote: > > > > I suggest simply reversing this patch at the moment. If Russell and > > > > Jens can tell me what they're trying to do I'll see if there's another > > > > way to do it. > > > > > > Reverted, with a big changelog entry to explain why. > > > > Great, I'm fucked by the SCSI folk again. > > > > Can we revert the patch which broke the MMC/SD layer - the one which > > added the mount/unmount hotplug events as well then. > > Why would the mount/unmount hotplug event change break MMC/SD? Do you > have a reference to the patch in question? Please read the commit message in the change in question. The block layer holds on to a reference to a struct device which isn't refcounted (until I added it with my patch.) Hence struct gendisk structures have a completely independent lifetime and are only destroyed when all references to them are removed. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/