Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next RFC 09/13] devlink: Add enable_remote_dev_reset
 generic parameter
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jiri Pirko <jiri@mellanox.com>,
        Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1595847753-2234-1-git-send-email-moshe@mellanox.com>
 <1595847753-2234-10-git-send-email-moshe@mellanox.com>
 <20200727175935.0785102a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <5baf2825-a550-f68f-f76e-3a8688aa6ae6@mellanox.com>
 <20200729135707.5fc65fc8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Moshe Shemesh <moshe@mellanox.com>
Message-ID: <f54924e8-eb3f-18ab-a016-276560086a5b@mellanox.com>
Date:   Thu, 30 Jul 2020 15:08:42 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20200729135707.5fc65fc8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.105] (5.102.195.53) by AM0PR01CA0174.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Thu, 30 Jul 2020 12:08:44 +0000
X-Originating-IP: [5.102.195.53]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 5caa96b1-72ad-4b82-f40b-08d834814eed
X-MS-TrafficTypeDiagnostic: DB6PR0501MB2647:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DB6PR0501MB2647E2104603DF220A675FF2D9710@DB6PR0501MB2647.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jb6H4X8yXPHmHsZl10vnRadgSTEjsN6qmWuwpWQi+r3qP+er3GhdPFfROGkTu5CVuQiktRKfZavGSj7evvtdxS9AVXRIVtJg0akbxfNSxScAl2f3+4hYtKe2Hn5u4JCfXniiL66o2QCp9lIhJ4L3W7aCscACR2lYjTOb0MqAEiPBXbGKymoMli1VBpKlpkPal5Cjw6x0dsfQl8dmyPtKtLtljMjA8RFqV+zxZZ8nElNniPSyo6/Gz9BVD6wLrymvEXQwWXeqZFrckwYtHnx251AGokurXE1emnucf2pZsCwRjJkqgd0S8Nc/iNxAYUwInGtwyv4ujMvK7OlGizhLY94T0KEmxlWUhSJwxdP3xKImYaMw6yJR9jvSJacf06EaRibh+FaoPLQURxnR92iAXQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR05MB4298.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(2906002)(86362001)(66946007)(8676002)(66556008)(16576012)(83380400001)(8936002)(31696002)(316002)(66476007)(54906003)(478600001)(956004)(26005)(186003)(6916009)(52116002)(5660300002)(4326008)(2616005)(6486002)(36756003)(31686004)(53546011)(16526019)(41533002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: WQKOQKk9MyPgaKDdpQ2e1i2K/lSBtExS9TF8KsdcS4y4c6lkVQbvx9goOZ3tL2my/Xo/y4x+CMBFx9C8g+Vt4OTxVXLxpvbJ112nevJGStLYRiBFYI/xk2IeIpQcTnLsD119f+Y0+6xFeO2RupSxk79Vyr08DUaAER7BR3d2BshNZ6QqqGnNX1d5pihGwukH3wvyCSi/FyDUQWh9bWo27D3zw5gXCPuUimuyztok5sRR4ATtigB80LUk2JRpGJRVOKaLowpgJT46R46k2ciaQLO65g1MeuBgDHLmlCq+V/qOD7vaanDeycuBvhZRwIWYRt7LzF7c6Oo8MFvHnJMnqjU39g39zali30mhnaEtcjlHjKyJLj25SUXURhLh4FYcjAmm9KC9CEseN2XiLj3uBzSC39YFuogXNMSvpuXA3JcTup1D3ZycEu04MIC1xGBa3OBnnIMxmyTFmacmJ2RxsVzkRmduX0WbrCE6bOD42f4=
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5caa96b1-72ad-4b82-f40b-08d834814eed
X-MS-Exchange-CrossTenant-AuthSource: DB7PR05MB4298.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2020 12:08:45.6675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EiwHt/2nQoeBiEMI18NLgBpDN77h0ibnYlTtsNkqVfFlM8jaloJNuHSAaSEOrWMsAlmjRNvQqRBgbmF8eHHEuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2647
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/29/2020 11:57 PM, Jakub Kicinski wrote:
> On Wed, 29 Jul 2020 17:42:12 +0300 Moshe Shemesh wrote:
>> On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
>>> On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
>>>> The enable_remote_dev_reset devlink param flags that the host admin
>>>> allows device resets that can be initiated by other hosts. This
>>>> parameter is useful for setups where a device is shared by different
>>>> hosts, such as multi-host setup. Once the user set this parameter to
>>>> false, the driver should NACK any attempt to reset the device while the
>>>> driver is loaded.
>>>>
>>>> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
>>> There needs to be a devlink event generated when reset is triggered
>>> (remotely or not).
>>>
>>> You're also missing failure reasons. Users need to know if the reset
>>> request was clearly nacked by some host, not supported, etc. vs
>>> unexpected failure.
>> I will fix and send extack message to the user accordingly.
> I'd suggest the reason codes to be somewhat standard.
>
> The groups I can think of:
>   - timeout - device did not respond to the reset request
>   - device reject - FW or else has nacked the activation req
>   - host incapable - one of the participating hosts (in MH) is not
>     capable of handling live activation
>   - host denied - one of the participating hosts has NACKed
>   - host timeout - one of the p. hosts did not ack or done the procedure
>     in time (e.g. has not toggled the link)
>   - failed reset - the activation itself had failed
>   - failed reinit - one of p. hosts was not able to cleanly come back up


Sounds good, that seems to cover all options of fw_reset process to fail.